commit 2d4c533ac39dbfba7b051c10c0ec5851a72c97a5
author Lei Zhang <thestig@chromium.org> Mon Jul 29 18:53:07 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 29 18:53:07 2024 +0000
tree 811f028e8b238d509caf6d9058bcba6f551ddb66
parent 7a9c22bd49bdc66f00f01f23fedd14272b6a6858

Simplify part of CFX_DIBitmap::ConvertFormat()

Call SetUniformOpaqueAlpha() instead of reimplementing it.

Change-Id: If64b5c6fecade5cc9dbc55a26bfdb5c9db555f6f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/122613
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fxge/dib/cfx_dibitmap.cpp

diff --git a/core/fxge/dib/cfx_dibitmap.cpp b/core/fxge/dib/cfx_dibitmap.cpp
index 3eb6d8f..985747a 100644
--- a/core/fxge/dib/cfx_dibitmap.cpp
+++ b/core/fxge/dib/cfx_dibitmap.cpp
@@ -849,15 +849,7 @@
   if (dest_format == FXDIB_Format::kArgb &&
       GetFormat() == FXDIB_Format::kRgb32) {
     SetFormat(FXDIB_Format::kArgb);
-    UNSAFE_TODO({
-      for (int row = 0; row < GetHeight(); row++) {
-        uint8_t* scanline = m_pBuffer.Get() + row * GetPitch() + 3;
-        for (int col = 0; col < GetWidth(); col++) {
-          *scanline = 0xff;
-          scanline += 4;
-        }
-      }
-    });
+    SetUniformOpaqueAlpha();
     return true;
   }
   int dest_bpp = GetBppFromFormat(dest_format);