commit 304b383c8c020648766033ffc00451e836309fdb
author Tom Sepez <tsepez@chromium.org> Thu Mar 20 15:52:48 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 20 15:52:48 2025 -0700
tree 3c9a052bcfa5f738c8783e8fc78277ba8e9efc0f
parent 30130534eb3b172b5e06e0afe9a36e2743f5d15d

Avoid another memset in scan line compositor.

Prefer fxcrt::Fill to memset().

Change-Id: I20223d73315eda70ef1aa16ccda0d594248352bb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129830
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fxge/dib/cfx_scanlinecompositor.cpp

diff --git a/core/fxge/dib/cfx_scanlinecompositor.cpp b/core/fxge/dib/cfx_scanlinecompositor.cpp
index 6166e0f..683d750 100644
--- a/core/fxge/dib/cfx_scanlinecompositor.cpp
+++ b/core/fxge/dib/cfx_scanlinecompositor.cpp
@@ -192,13 +192,13 @@
 void CompositeRow_Rgb2Mask(pdfium::span<uint8_t> dest_span,
                            int width,
                            pdfium::span<const uint8_t> clip_span) {
+  if (clip_span.empty()) {
+    fxcrt::Fill(dest_span.first(width), 0xff);
+    return;
+  }
   uint8_t* dest_scan = dest_span.data();
   const uint8_t* clip_scan = clip_span.data();
   UNSAFE_TODO({
-    if (!clip_scan) {
-      FXSYS_memset(dest_scan, 0xff, width);
-      return;
-    }
     for (int i = 0; i < width; ++i) {
       *dest_scan = AlphaUnion(*dest_scan, *clip_scan);
       ++dest_scan;