commit 30540a95637256412eab3e87f954ee2b9793678f
author Lei Zhang <thestig@chromium.org> Thu Oct 04 22:31:12 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Oct 04 22:31:12 2018 +0000
tree beebd9152140f22869e859faa24e5bfc90d3e0bb
parent 7b0ff3c93dfb4925da5495794fde0fff1a68c9d1

Remove unreachable code in CPDFXFA_Page.

Also disambiguate LoadPDFPage() and do some cleanups.

Change-Id: I591295cd5e742a14e41149b63e9d11d8c3d5b7fd
Reviewed-on: https://pdfium-review.googlesource.com/c/43460
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_editpage.cpp

diff --git a/fpdfsdk/fpdf_editpage.cpp b/fpdfsdk/fpdf_editpage.cpp
index c71f7e2..d9a9bef 100644
--- a/fpdfsdk/fpdf_editpage.cpp
+++ b/fpdfsdk/fpdf_editpage.cpp
@@ -223,7 +223,7 @@
   auto* pContext = static_cast<CPDFXFA_Context*>(pDoc->GetExtension());
   if (pContext) {
     auto pXFAPage = pdfium::MakeRetain<CPDFXFA_Page>(pContext, page_index);
-    pXFAPage->LoadPDFPage(pPageDict);
+    pXFAPage->LoadPDFPageFromDict(pPageDict);
     return FPDFPageFromIPDFPage(pXFAPage.Leak());  // Caller takes ownership.
   }
 #endif  // PDF_ENABLE_XFA