commit 33b2eb48e49d0d7b86e974866598a50b13667b68
author Tom Sepez <tsepez@chromium.org> Mon Mar 17 16:02:18 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 17 16:02:18 2025 -0700
tree f3a32e5a4f701325e13e2abc802871897cfbd3ae
parent fad67dead8d87f4c40781c520157ccdea98e37f8

Make CXFA_LocaleValue::SetDate(), SetTime() and SetDateTime() void.

These all return true and the value is never used.

Change-Id: I6651c19c9e25c290db6f72221bb36034f4ab3375
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129554
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>

xfa/fxfa/parser/cxfa_localevalue.cpp

diff --git a/xfa/fxfa/parser/cxfa_localevalue.cpp b/xfa/fxfa/parser/cxfa_localevalue.cpp
index 6183f0d..cde836f 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.cpp
+++ b/xfa/fxfa/parser/cxfa_localevalue.cpp
@@ -244,30 +244,27 @@
   return dt;
 }
 
-bool CXFA_LocaleValue::SetDate(const CFX_DateTime& d) {
+void CXFA_LocaleValue::SetDate(const CFX_DateTime& d) {
   m_eType = CXFA_LocaleValue::ValueType::kDate;
   m_wsValue = WideString::Format(L"%04d-%02d-%02d", d.GetYear(), d.GetMonth(),
                                  d.GetDay());
-  return true;
 }
 
-bool CXFA_LocaleValue::SetTime(const CFX_DateTime& t) {
+void CXFA_LocaleValue::SetTime(const CFX_DateTime& t) {
   m_eType = CXFA_LocaleValue::ValueType::kTime;
   m_wsValue = WideString::Format(L"%02d:%02d:%02d", t.GetHour(), t.GetMinute(),
                                  t.GetSecond());
   if (t.GetMillisecond() > 0)
     m_wsValue += WideString::Format(L"%:03d", t.GetMillisecond());
-  return true;
 }
 
-bool CXFA_LocaleValue::SetDateTime(const CFX_DateTime& dt) {
+void CXFA_LocaleValue::SetDateTime(const CFX_DateTime& dt) {
   m_eType = CXFA_LocaleValue::ValueType::kDateTime;
   m_wsValue = WideString::Format(L"%04d-%02d-%02dT%02d:%02d:%02d", dt.GetYear(),
                                  dt.GetMonth(), dt.GetDay(), dt.GetHour(),
                                  dt.GetMinute(), dt.GetSecond());
   if (dt.GetMillisecond() > 0)
     m_wsValue += WideString::Format(L"%:03d", dt.GetMillisecond());
-  return true;
 }
 
 bool CXFA_LocaleValue::FormatPatterns(WideString& wsResult,

xfa/fxfa/parser/cxfa_localevalue.h

diff --git a/xfa/fxfa/parser/cxfa_localevalue.h b/xfa/fxfa/parser/cxfa_localevalue.h
index d7809c0..a0bc793 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.h
+++ b/xfa/fxfa/parser/cxfa_localevalue.h
@@ -68,7 +68,7 @@
   const WideString& GetValue() const { return m_wsValue; }
   ValueType GetType() const { return m_eType; }
   double GetDoubleNum() const;
-  bool SetDate(const CFX_DateTime& d);
+  void SetDate(const CFX_DateTime& d);
   CFX_DateTime GetDate() const;
   CFX_DateTime GetTime() const;
 
@@ -81,8 +81,8 @@
   bool ValidateCanonicalDate(const WideString& wsDate, CFX_DateTime* unDate);
   bool ValidateCanonicalTime(const WideString& wsTime);
 
-  bool SetTime(const CFX_DateTime& t);
-  bool SetDateTime(const CFX_DateTime& dt);
+  void SetTime(const CFX_DateTime& t);
+  void SetDateTime(const CFX_DateTime& dt);
 
   bool ParsePatternValue(const WideString& wsValue,
                          const WideString& wsPattern,