commit 3f09961559b533110ac114eeef7baa9fcb4ab668
author Lei Zhang <thestig@chromium.org> Wed Apr 19 17:59:11 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 19 17:59:11 2023 +0000
tree 25c931bf142f883d064f5d418cee82824dea924f
parent da78dcba45957376ac6ede3085d80903b7e2149e

Represent fxcmap::CMap::MapType with a bool

Since this enum only has 2 values, use a bool to represent it. Then the
switch statements that check this enum no longer need the default cases.

Change-Id: I6700dbec0467f2ea820b97ca67b645b2dc829773
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/106233
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

core/fpdfapi/cmaps/fpdf_cmaps.cpp

diff --git a/core/fpdfapi/cmaps/fpdf_cmaps.cpp b/core/fpdfapi/cmaps/fpdf_cmaps.cpp
index 529106f..98187a1 100644
--- a/core/fpdfapi/cmaps/fpdf_cmaps.cpp
+++ b/core/fpdfapi/cmaps/fpdf_cmaps.cpp
@@ -9,7 +9,6 @@
 #include <algorithm>
 
 #include "third_party/base/check.h"
-#include "third_party/base/notreached.h"
 
 namespace fxcmap {
 
@@ -84,10 +83,6 @@
           return found->cid + loword - found->low;
         break;
       }
-      default: {
-        NOTREACHED();
-        break;
-      }
     }
     pMap = FindNextCMap(pMap);
   }
@@ -125,10 +120,6 @@
         }
         break;
       }
-      default: {
-        NOTREACHED();
-        break;
-      }
     }
     pMap = FindNextCMap(pMap);
   }

core/fpdfapi/cmaps/fpdf_cmaps.h

diff --git a/core/fpdfapi/cmaps/fpdf_cmaps.h b/core/fpdfapi/cmaps/fpdf_cmaps.h
index a5a052d..079459a 100644
--- a/core/fpdfapi/cmaps/fpdf_cmaps.h
+++ b/core/fpdfapi/cmaps/fpdf_cmaps.h
@@ -19,7 +19,7 @@
 };
 
 struct CMap {
-  enum class Type : uint8_t { kSingle, kRange };
+  enum class Type : bool { kSingle, kRange };
 
   const char* m_Name;              // Raw, POD struct.
   const uint16_t* m_pWordMap;      // Raw, POD struct.