commit 40c4fb881dad923c4dcbee3a9477e0a995f3bd04
author Bo Xu <bo_xu@foxitsoftware.com> Wed May 28 10:21:47 2014 -0700
committer Bo Xu <bo_xu@foxitsoftware.com> Wed May 28 10:21:47 2014 -0700
tree 63785fb01fa295f412b1dc089b874680aac6fa51
parent 17211aecc66bab2e7576b0d620499a315d6b68a7

Fix a security issue in FPDF_GetMetaText

BUG=security

Review URL: https://codereview.chromium.org/307653002

fpdfsdk/src/fpdfdoc.cpp

diff --git a/fpdfsdk/src/fpdfdoc.cpp b/fpdfsdk/src/fpdfdoc.cpp
index 4fa6ba2..edd61f9 100644
--- a/fpdfsdk/src/fpdfdoc.cpp
+++ b/fpdfsdk/src/fpdfdoc.cpp
@@ -249,7 +249,7 @@
 	// Use UTF-16LE encoding
 	CFX_ByteString bstr = text.UTF16LE_Encode();
 	unsigned long len = bstr.GetLength();
-	if (buffer != NULL || buflen >= len+2) {
+	if (buffer != NULL && buflen >= len+2) {
 		FXSYS_memcpy(buffer, (FX_LPCSTR)bstr, len);
 		// use double zero as trailer
 		((FX_BYTE*)buffer)[len] = ((FX_BYTE*)buffer)[len+1] = 0;