commit 4b4e4e8b9093cf352a8405c005304520b73cce84
author Lei Zhang <thestig@chromium.org> Fri Jul 21 19:00:49 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 21 19:00:49 2023 +0000
tree f6e1a959d2b3454c2ece9260944e401fc83e471b
parent 234ec6cb860dc1b30bde876152d5c828b0e94594

Speculative fix for crash in CGdiDeviceDriver::GDI_StretchDIBits()

Check for failed stretched operation and return false instead of
crashing.

Bug: chromium:1466498
Change-Id: Ieb37774a7a2b3df75c78437e4b211c4e4503d7f3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/110050
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxge/win32/cgdi_device_driver.cpp

diff --git a/core/fxge/win32/cgdi_device_driver.cpp b/core/fxge/win32/cgdi_device_driver.cpp
index b794a49..6ae582e 100644
--- a/core/fxge/win32/cgdi_device_driver.cpp
+++ b/core/fxge/win32/cgdi_device_driver.cpp
@@ -444,6 +444,9 @@
        (int64_t)abs(dest_width) * abs(dest_height))) {
     stretch_source = source->StretchTo(dest_width, dest_height,
                                        FXDIB_ResampleOptions(), nullptr);
+    if (!stretch_source) {
+      return false;
+    }
     info = GetBitmapInfo(stretch_source);
   }
   ::StretchDIBits(m_hDC, dest_left, dest_top, dest_width, dest_height, 0, 0,