commit 4e3d023b291d443610171f257f3497244ad4a82c
author Brian Osman <brianosman@google.com> Mon Jun 24 19:51:41 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 24 19:51:41 2024 +0000
tree 3eefab4472e1e8ea048594545c63d47804a9a68a
parent e91288092c3e2399eae5f37aa02916c8effd604f

Replace SkPackARGB32NoCheck with SkPackARGB32

The "valid" premul checks have been removed from SkPackARGB32, so these
functions are identical, and NoCheck is going away.

Bug: 40044764, 40044820
Change-Id: I8f7ab6302ecfe91f8234d0c6632bbf8a73caed00
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/120970
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>

core/fxge/skia/cfx_dibbase_skia.cpp

diff --git a/core/fxge/skia/cfx_dibbase_skia.cpp b/core/fxge/skia/cfx_dibbase_skia.cpp
index 7a86c73..4824666 100644
--- a/core/fxge/skia/cfx_dibbase_skia.cpp
+++ b/core/fxge/skia/cfx_dibbase_skia.cpp
@@ -229,7 +229,7 @@
       return CreateSkiaImageFromTransformedDib</*source_bits_per_pixel=*/24>(
           *this, kBGRA_8888_SkColorType, kOpaque_SkAlphaType,
           [](uint8_t red, uint8_t green, uint8_t blue) {
-            return SkPackARGB32NoCheck(0xFF, red, green, blue);
+            return SkPackARGB32(0xFF, red, green, blue);
           });
 
     case 32:

core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 8fcb945..98311d0 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -359,9 +359,9 @@
         float_colors[j] =
             colors_min[j] + (colors_max[j] - colors_min[j]) * interp;
       }
-      colors.push_back(SkPackARGB32NoCheck(0xFF, FloatToByte(float_colors[0]),
-                                           FloatToByte(float_colors[1]),
-                                           FloatToByte(float_colors[2])));
+      colors.push_back(SkPackARGB32(0xFF, FloatToByte(float_colors[0]),
+                                    FloatToByte(float_colors[1]),
+                                    FloatToByte(float_colors[2])));
       pos.push_back(static_cast<float>(i) / (sample_count - 1));
     }
   return true;