commit 4ede0790c3d6fd0c3978f81efd406441621b184d
author Tom Sepez <tsepez@chromium.org> Fri Oct 07 20:25:36 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 07 20:25:36 2022 +0000
tree 4063c703d266e1cd1b95bdc0a96282e849b8f51b
parent 57595d4af9ee4b2e003a9fca79264f0acc597e61

Return retained references from CPDF_PageObjectHolder methods.

Propagate these into a few called methods.

-- fix some local names while at it.

Change-Id: Ib03a04672baf7a63cfdc8b33370c16f8a5cc7200
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/99010
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_editpage.cpp

diff --git a/fpdfsdk/fpdf_editpage.cpp b/fpdfsdk/fpdf_editpage.cpp
index 2d6ff76..fbc059b 100644
--- a/fpdfsdk/fpdf_editpage.cpp
+++ b/fpdfsdk/fpdf_editpage.cpp
@@ -67,7 +67,7 @@
   if (!pPage)
     return false;
 
-  const CPDF_Dictionary* pFormDict = pPage->GetDict();
+  RetainPtr<const CPDF_Dictionary> pFormDict = pPage->GetDict();
   if (!pFormDict->KeyExist(pdfium::page_object::kType))
     return false;