commit 4f21d77576b371270375f1120cba5cf99c248e9d
author Ryan Harrison <rharrison@chromium.org> Fri Jun 01 15:19:04 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Jun 01 15:19:04 2018 +0000
tree 2d30a1bbed27764c7c884401ab412343cf45592c
parent 2d11d72e326140b9abeb6de2db1e28e5bf9d7e64

Fix V8 guards

These guards are using #if, when they should be using #ifdef. Caught
using Clang's static analyzer.

Change-Id: I9bb7a4c2b817e752c04b21a8321595f9676d6381
Reviewed-on: https://pdfium-review.googlesource.com/33511
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

samples/pdfium_test.cc

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index e2e386f..d2e8487 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -283,7 +283,7 @@
       options->save_attachments = true;
     } else if (cur_arg == "--save-images") {
       options->save_images = true;
-#if PDF_ENABLE_V8
+#ifdef PDF_ENABLE_V8
     } else if (cur_arg == "--disable-javascript") {
       options->disable_javascript = true;
 #ifdef PDF_ENABLE_XFA

testing/unit_test_main.cpp

diff --git a/testing/unit_test_main.cpp b/testing/unit_test_main.cpp
index 8d8755e..92dceef 100644
--- a/testing/unit_test_main.cpp
+++ b/testing/unit_test_main.cpp
@@ -10,10 +10,10 @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/test_support.h"
 
-#if PDF_ENABLE_V8
+#ifdef PDF_ENABLE_V8
 #include "v8/include/v8-platform.h"
 #include "v8/include/v8.h"
-#endif
+#endif  // PDF_ENABLE_V8
 
 #if PDF_ENABLE_XFA
 #include "core/fxge/cfx_fontmgr.h"