commit 55ccb526913debb3269a33792bbd61b05656ec46
author Tom Sepez <tsepez@chromium.org> Tue Aug 14 23:40:10 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Aug 14 23:40:10 2018 +0000
tree a98152baf9d4a5dcf1c76ecaf53cbae35720d2b8
parent 48d62c3a5f57eb3397a335bea4a5a30de2fcb955

Remove optional argument from NewFXJSBoundObject().

Additionally, we have a pre-existing enum type that is more
meaningful than just a boolean.

Change-Id: Ie6ad13a3c9b22e34dedf7a5a9b5b9cc2a49b1f03
Reviewed-on: https://pdfium-review.googlesource.com/40190
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/cjs_field.cpp

diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp
index cd97372..45715e2 100644
--- a/fxjs/cjs_field.cpp
+++ b/fxjs/cjs_field.cpp
@@ -2274,8 +2274,8 @@
   if (!pFormControl)
     return CJS_Return(JSMessage::kBadObjectError);
 
-  v8::Local<v8::Object> pObj =
-      pRuntime->NewFXJSBoundObject(CJS_Icon::GetObjDefnID());
+  v8::Local<v8::Object> pObj = pRuntime->NewFXJSBoundObject(
+      CJS_Icon::GetObjDefnID(), FXJSOBJTYPE_DYNAMIC);
   if (pObj.IsEmpty())
     return CJS_Return(JSMessage::kBadObjectError);
 
@@ -2386,8 +2386,8 @@
   v8::Local<v8::Array> FormFieldArray = pRuntime->NewArray();
   int j = 0;
   for (const auto& pStr : swSort) {
-    v8::Local<v8::Object> pObj =
-        pRuntime->NewFXJSBoundObject(CJS_Field::GetObjDefnID());
+    v8::Local<v8::Object> pObj = pRuntime->NewFXJSBoundObject(
+        CJS_Field::GetObjDefnID(), FXJSOBJTYPE_DYNAMIC);
     if (pObj.IsEmpty())
       return CJS_Return(JSMessage::kBadObjectError);