commit 584ed1206e7305bd8bda34bf2aac52105ff76ed2
author Lei Zhang <thestig@chromium.org> Mon Apr 04 20:12:08 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 04 20:12:08 2022 +0000
tree b5a281d1c48591d480db2d5d7b07e3bde6c96c12
parent b120f2cc2a4b4916aac974ab0b7b6a7b67be485a

Fix some nits in XFA widget code.

- Document CXFA_FFDoc::WidgetPostAdd() and WidgetPreRemove() should
  never receive a nullptr for the widget argument. Remove the
  corresponding nullptr check in the implementation.
- For consistency rename several related methods in CPDFSDK_PageView:
  AddAnnot()             -> AddAnnotForFFWidget()
  DeleteAnnotForWidget() -> DeleteAnnotForFFWidget()
  GetAnnotByXFAWidget()  -> GetAnnotForFFWidget()

Change-Id: I644d35cdbf741c93e84cc2a458105e77dd8b123e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92133
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/cpdfsdk_pageview.h

diff --git a/fpdfsdk/cpdfsdk_pageview.h b/fpdfsdk/cpdfsdk_pageview.h
index da1532c..83460ed 100644
--- a/fpdfsdk/cpdfsdk_pageview.h
+++ b/fpdfsdk/cpdfsdk_pageview.h
@@ -53,9 +53,9 @@
   CPDFSDK_Annot* GetAnnotByDict(CPDF_Dictionary* pDict);
 
 #ifdef PDF_ENABLE_XFA
-  void DeleteAnnotForWidget(CXFA_FFWidget* pWidget);
-  CPDFSDK_Annot* AddAnnot(CXFA_FFWidget* pPDFAnnot);
-  CPDFSDK_Annot* GetAnnotByXFAWidget(CXFA_FFWidget* pWidget);
+  CPDFSDK_Annot* AddAnnotForFFWidget(CXFA_FFWidget* pWidget);
+  void DeleteAnnotForFFWidget(CXFA_FFWidget* pWidget);
+  CPDFSDK_Annot* GetAnnotForFFWidget(CXFA_FFWidget* pWidget);
   IPDF_Page* GetXFAPage();
 #endif  // PDF_ENABLE_XFA