commit 590f4247e2358d258a06cc447c1ae89730184cc5
author Lei Zhang <thestig@chromium.org> Wed May 15 20:57:26 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed May 15 20:57:26 2019 +0000
tree 8e8a7bd7c3727ce34ac262ba4ed1f6f1048aea94
parent 4dc653963a7e702eccf78514b61ebfda1515dbe3

Fix nits involving 'constexpr const' code.

- Mark constants not in anonymous namespaces as static.
- Rename constants to kFoo.
- Remove constexpr or const if having both is redundant.
- Change one unsigned long variable to size_t.

Change-Id: Id1fb2f2d56ec659622123546b8c709f9df3f8caf
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52873
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_ppo_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_ppo_embeddertest.cpp b/fpdfsdk/fpdf_ppo_embeddertest.cpp
index 8b36045..8072d86 100644
--- a/fpdfsdk/fpdf_ppo_embeddertest.cpp
+++ b/fpdfsdk/fpdf_ppo_embeddertest.cpp
@@ -103,7 +103,7 @@
 TEST_F(FPDFPPOEmbedderTest, NupRenderImage) {
   ASSERT_TRUE(OpenDocument("rectangles_multi_pages.pdf"));
   const int kPageCount = 2;
-  constexpr const char* kExpectedMD5s[kPageCount] = {
+  static constexpr const char* kExpectedMD5s[kPageCount] = {
       "4d225b961da0f1bced7c83273e64c9b6", "fb18142190d770cfbc329d2b071aee4d"};
   ScopedFPDFDocument output_doc_3up(
       FPDF_ImportNPagesToOne(document(), 792, 612, 3, 1));