commit 5af51b698dc1e49e9d8a943c9f0c60ce1e4b4f12
author Daniel Hosseinian <dhoss@chromium.org> Sat Jul 18 00:53:43 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat Jul 18 00:53:43 2020 +0000
tree 15f89ba0ee3e2a411390f71424ec51b897ab74fa
parent 0ac7b4ef4a6631a564a3b7a6f81edf604032b87c

Mass assert OpenDocument*() in tests

Opening a document is a prerequisite to all tests that open a document,
and success should be tested with an ASSERT instead of an EXPECT.

Done with simple search and replace with
sed -i 's/EXPECT_TRUE(OpenDocument/ASSERT_TRUE(OpenDocument/g'

Change-Id: Ia2ad22a3863b138d9222b821ddec372915c784df
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/71654
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>

fpdfsdk/fpdf_flatten_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_flatten_embeddertest.cpp b/fpdfsdk/fpdf_flatten_embeddertest.cpp
index 112a322..38ed906 100644
--- a/fpdfsdk/fpdf_flatten_embeddertest.cpp
+++ b/fpdfsdk/fpdf_flatten_embeddertest.cpp
@@ -15,7 +15,7 @@
 }  // namespace
 
 TEST_F(FPDFFlattenEmbedderTest, FlatNothing) {
-  EXPECT_TRUE(OpenDocument("hello_world.pdf"));
+  ASSERT_TRUE(OpenDocument("hello_world.pdf"));
   FPDF_PAGE page = LoadPage(0);
   EXPECT_TRUE(page);
   EXPECT_EQ(FLATTEN_NOTHINGTODO, FPDFPage_Flatten(page, FLAT_NORMALDISPLAY));
@@ -23,7 +23,7 @@
 }
 
 TEST_F(FPDFFlattenEmbedderTest, FlatNormal) {
-  EXPECT_TRUE(OpenDocument("annotiter.pdf"));
+  ASSERT_TRUE(OpenDocument("annotiter.pdf"));
   FPDF_PAGE page = LoadPage(0);
   EXPECT_TRUE(page);
   EXPECT_EQ(FLATTEN_SUCCESS, FPDFPage_Flatten(page, FLAT_NORMALDISPLAY));
@@ -31,7 +31,7 @@
 }
 
 TEST_F(FPDFFlattenEmbedderTest, FlatPrint) {
-  EXPECT_TRUE(OpenDocument("annotiter.pdf"));
+  ASSERT_TRUE(OpenDocument("annotiter.pdf"));
   FPDF_PAGE page = LoadPage(0);
   EXPECT_TRUE(page);
   EXPECT_EQ(FLATTEN_SUCCESS, FPDFPage_Flatten(page, FLAT_PRINT));
@@ -53,7 +53,7 @@
   constexpr char kCheckboxHash[] = "594265790b81df2d93120d33b72a6ada";
 #endif
 
-  EXPECT_TRUE(OpenDocument("bug_861842.pdf"));
+  ASSERT_TRUE(OpenDocument("bug_861842.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
@@ -82,7 +82,7 @@
   constexpr char kFlattenedPageHash[] = "ef01f57507662ec9aef7cc7cff92f96c";
 #endif
 
-  EXPECT_TRUE(OpenDocument("bug_889099.pdf"));
+  ASSERT_TRUE(OpenDocument("bug_889099.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
@@ -106,7 +106,7 @@
 #endif
 TEST_F(FPDFFlattenEmbedderTest, MAYBE_BUG_890322) {
   constexpr char md5_hash[] = "6c674642154408e877d88c6c082d67e9";
-  EXPECT_TRUE(OpenDocument("bug_890322.pdf"));
+  ASSERT_TRUE(OpenDocument("bug_890322.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
@@ -129,7 +129,7 @@
 #endif
 TEST_F(FPDFFlattenEmbedderTest, MAYBE_BUG_896366) {
   constexpr char md5_hash[] = "f71ab085c52c8445ae785eca3ec858b1";
-  EXPECT_TRUE(OpenDocument("bug_896366.pdf"));
+  ASSERT_TRUE(OpenDocument("bug_896366.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);