commit 5b115ea3f57135a780443fd9a9bc0ff0b71ab14c
author Tom Sepez <tsepez@chromium.org> Tue Jun 27 15:33:01 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 27 15:33:01 2023 +0000
tree 7b7fd4ab918bac2f6fa2c752103e447c9c3750f2
parent 21ac43e7fb73582dec513672d8a6c5f3908d441b

Remove unused out param from IsIsoDateFormat()

Callers ignore the pStyle return value.

Change-Id: I6c88581744f805896edc5366b7cd19fddc1fefee
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/109031
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/xfa/cfxjse_formcalc_context.cpp

diff --git a/fxjs/xfa/cfxjse_formcalc_context.cpp b/fxjs/xfa/cfxjse_formcalc_context.cpp
index 695cc25..fab90c5 100644
--- a/fxjs/xfa/cfxjse_formcalc_context.cpp
+++ b/fxjs/xfa/cfxjse_formcalc_context.cpp
@@ -512,11 +512,9 @@
 }
 
 bool IsIsoDateFormat(pdfium::span<const char> pData,
-                     int32_t* pStyle,
                      int32_t* pYear,
                      int32_t* pMonth,
                      int32_t* pDay) {
-  int32_t& iStyle = *pStyle;
   int32_t& iYear = *pYear;
   int32_t& iMonth = *pMonth;
   int32_t& iDay = *pDay;
@@ -537,12 +535,10 @@
     szYear[i] = pData[i];
   }
   iYear = FXSYS_atoi(szYear);
-  iStyle = 0;
   if (pData.size() == 4)
     return true;
 
-  iStyle = pData[4] == '-' ? 1 : 0;
-
+  int32_t iStyle = pData[4] == '-' ? 1 : 0;
   size_t iPosOff = iStyle == 0 ? 4 : 5;
   if (!isdigit(pData[iPosOff]) || !isdigit(pData[iPosOff + 1]))
     return false;
@@ -754,9 +750,7 @@
 
   pdfium::span<const char> pDateSpan = pData.subspan(0, iIndex);
   pdfium::span<const char> pTimeSpan = pData.subspan(iIndex + 1);
-
-  int32_t iStyle = -1;
-  return IsIsoDateFormat(pDateSpan, &iStyle, pYear, pMonth, pDay) &&
+  return IsIsoDateFormat(pDateSpan, pYear, pMonth, pDay) &&
          IsIsoTimeFormat(pTimeSpan, pHour, pMinute, pSecond, pMilliSecond,
                          pZoneHour, pZoneMinute);
 }
@@ -767,9 +761,9 @@
   int32_t iMonth = 0;
   int32_t iDay = 0;
   if (iLength <= 10) {
-    int32_t iStyle = -1;
-    if (!IsIsoDateFormat(bsDate.span(), &iStyle, &iYear, &iMonth, &iDay))
+    if (!IsIsoDateFormat(bsDate.span(), &iYear, &iMonth, &iDay)) {
       return 0;
+    }
   } else {
     int32_t iHour = 0;
     int32_t iMinute = 0;