commit 5c88f7b546997bffa2918582d31e2c7cfa9f986c
author Lei Zhang <thestig@chromium.org> Tue Jul 12 21:39:56 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 12 21:39:56 2022 +0000
tree 7d10bf5cca7e977387186c9291afa046f2322d59
parent 640e18b43992f0c5d1771570622999db45a5173a

Remove an impossible check in CXFA_FWLTheme::CalcTextRect().

The `m_pTextOut` member is only null after the pre-finalizer runs. At
that point, nobody should be calling into a dead object.

Change-Id: Icbff4202cc2118f5cc2449e1cd42c98456d2c549
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/95051
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

xfa/fxfa/cxfa_fwltheme.cpp

diff --git a/xfa/fxfa/cxfa_fwltheme.cpp b/xfa/fxfa/cxfa_fwltheme.cpp
index c1b9428..3457fae 100644
--- a/xfa/fxfa/cxfa_fwltheme.cpp
+++ b/xfa/fxfa/cxfa_fwltheme.cpp
@@ -229,9 +229,6 @@
 
 void CXFA_FWLTheme::CalcTextRect(const CFWL_ThemeText& pParams,
                                  CFX_RectF* pRect) {
-  if (!m_pTextOut)
-    return;
-
   CXFA_FFWidget* pWidget = GetOutmostFFWidget(pParams.GetWidget());
   if (!pWidget)
     return;