commit 5f814e878ea7bc7202a9fe3f0a68577ed62bcf52
author Lei Zhang <thestig@chromium.org> Mon Nov 06 19:03:14 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 06 19:03:14 2023 +0000
tree 5f4373555cba7f456aa8c10634d4adf68296b984
parent 9be49d4b0ecf9790e477191d2935a37431c4ea8a

Fulfill a TODO in cpdf_dib.cpp

The BPP value in CalculateBitsPerPixel() is never 0, because the only
caller checks the bit-per-component and component count values to make
sure they are not 0.

Change-Id: Ia00f3b25eebde0b0b2d535b32363a8db167df8c0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/113333
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_dib.cpp

diff --git a/core/fpdfapi/page/cpdf_dib.cpp b/core/fpdfapi/page/cpdf_dib.cpp
index 657cf16..cb8de1c 100644
--- a/core/fpdfapi/page/cpdf_dib.cpp
+++ b/core/fpdfapi/page/cpdf_dib.cpp
@@ -89,8 +89,8 @@
 }
 
 int CalculateBitsPerPixel(uint32_t bpc, uint32_t comps) {
-  // TODO(thestig): Can |bpp| be 0 here? Add an DCHECK() or handle it?
   uint32_t bpp = bpc * comps;
+  CHECK(bpp);
   if (bpp == 1)
     return 1;
   if (bpp <= 8)