commit 601809edf37f4ffdda8673aeb80571bf386adc72
author Lei Zhang <thestig@chromium.org> Fri Mar 22 17:54:39 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Mar 22 17:54:39 2019 +0000
tree 85d649b51a60cd066112f7ed99b9a466d65d1a83
parent 857ae9fe9cb9c8e9c450395f4f11f99f99eb86c4

Avoid a CHECK failure inside CXFA_AttachNodeList::Insert().

Make sure the node to insert before, when it exists, is actually a
member of the CXFA_AttachNodeList. Give CXFA_List::Insert() a return
value, so when the validation fails, the caller can indicate failure.

BUG=pdfium:1263

Change-Id: Ia11f94a2407281694080d42cddbcc1c076bde5c9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52177
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/BUILD.gn

diff --git a/fxjs/BUILD.gn b/fxjs/BUILD.gn
index ae3befc..30648f9 100644
--- a/fxjs/BUILD.gn
+++ b/fxjs/BUILD.gn
@@ -252,6 +252,7 @@
         "xfa/cfxjse_formcalc_context_embeddertest.cpp",
         "xfa/cfxjse_value_embeddertest.cpp",
         "xfa/cjx_hostpseudomodel_embeddertest.cpp",
+        "xfa/cjx_list_embeddertest.cpp",
       ]
       deps += [ "../xfa/fxfa" ]
     }