Introduce enum class XFA_EventError.
Presently, the code is using int32_t for these status codes,
and is doing so inconsistently, sometimes returning true/false
and sometimes or-ing the bits together. The enum class prevents
these abuses.
Change-Id: Ife1a7296b20fabb6789e35c197cae2018b34e5a2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57070
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/xfa/fxfa/cxfa_ffdocview.h b/xfa/fxfa/cxfa_ffdocview.h
index 3752527..e9a094f 100644
--- a/xfa/fxfa/cxfa_ffdocview.h
+++ b/xfa/fxfa/cxfa_ffdocview.h
@@ -14,6 +14,7 @@
#include "core/fxcrt/unowned_ptr.h"
#include "xfa/fxfa/cxfa_eventparam.h"
#include "xfa/fxfa/cxfa_ffdoc.h"
+#include "xfa/fxfa/fxfa.h"
class CXFA_BindItems;
class CXFA_FFDoc;
@@ -86,10 +87,10 @@
CXFA_Node* GetFocusNode() const { return m_pFocusNode.Get(); }
void SetFocusNode(CXFA_Node* pNode);
void DeleteLayoutItem(CXFA_FFWidget* pWidget);
- int32_t ExecEventActivityByDeepFirst(CXFA_Node* pFormNode,
- XFA_EVENTTYPE eEventType,
- bool bIsFormReady,
- bool bRecursive);
+ XFA_EventError ExecEventActivityByDeepFirst(CXFA_Node* pFormNode,
+ XFA_EVENTTYPE eEventType,
+ bool bIsFormReady,
+ bool bRecursive);
void AddBindItem(CXFA_BindItems* item) { m_BindItems.push_back(item); }
@@ -112,7 +113,7 @@
bool IsUpdateLocked() { return m_iLock > 0; }
bool InitValidate(CXFA_Node* pNode);
bool RunValidate();
- int32_t RunCalculateWidgets();
+ XFA_EventError RunCalculateWidgets();
void RunSubformIndexChange();
UnownedPtr<CXFA_FFDoc> const m_pDoc;