commit 640f6bfbf52a84c40945444484408d455954e67d
author Lei Zhang <thestig@chromium.org> Tue Jun 07 22:47:40 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 07 22:47:40 2022 +0000
tree 9209407df81a8919f5214cb1ed33704205520bf0
parent 238933f39596f51ca11e3ac32f40bc7e6a1a6d11

Remove debugging code in CPDF_TextObject dtor.

The crash the deleted code is trying to catch barely registers on the
crash server and is not worth investigating.

Bug: chromium:782215
Change-Id: Iffc88ba3cd6ccbc015b6329002013ce60874da67
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93990
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_textobject.cpp

diff --git a/core/fpdfapi/page/cpdf_textobject.cpp b/core/fpdfapi/page/cpdf_textobject.cpp
index bb6a1b8..fbb5aa0 100644
--- a/core/fpdfapi/page/cpdf_textobject.cpp
+++ b/core/fpdfapi/page/cpdf_textobject.cpp
@@ -7,7 +7,6 @@
 #include "core/fpdfapi/page/cpdf_textobject.h"
 
 #include <algorithm>
-#include <utility>
 
 #include "core/fpdfapi/font/cpdf_cidfont.h"
 #include "core/fpdfapi/font/cpdf_font.h"
@@ -27,11 +26,7 @@
 
 CPDF_TextObject::CPDF_TextObject() : CPDF_TextObject(kNoContentStream) {}
 
-CPDF_TextObject::~CPDF_TextObject() {
-  // Move m_CharCodes to a local variable so it will be captured in crash dumps,
-  // to help with investigating crbug.com/782215.
-  auto char_codes_copy = std::move(m_CharCodes);
-}
+CPDF_TextObject::~CPDF_TextObject() = default;
 
 size_t CPDF_TextObject::CountItems() const {
   return m_CharCodes.size();