commit 6955aa6ab13a078b00fb311310fca99bf51d5043
author Tom Sepez <tsepez@chromium.org> Sat Jun 25 00:38:31 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jun 25 00:38:31 2022 +0000
tree 50cdc90dd486085803b1f15aebc128dc68a85ef0
parent 228fb2f9611594fd3f990452b9d04c3df9a41e57

Add const to FPDF_PAGERANGE declaration.

Then make conversion in helper functions return const, too.
Enables significantly easier conversions in subsequent CLs. It is
packaged into a standalone CL since it is a public change.

Change-Id: I10fa98ce3558e15a1ba0fa3fa555743424a43846
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94672
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_helpers.h

diff --git a/fpdfsdk/cpdfsdk_helpers.h b/fpdfsdk/cpdfsdk_helpers.h
index c339b80..429754f 100644
--- a/fpdfsdk/cpdfsdk_helpers.h
+++ b/fpdfsdk/cpdfsdk_helpers.h
@@ -151,11 +151,11 @@
   return reinterpret_cast<CPDF_ContentMarkItem*>(mark);
 }
 
-inline FPDF_PAGERANGE FPDFPageRangeFromCPDFArray(CPDF_Array* range) {
+inline FPDF_PAGERANGE FPDFPageRangeFromCPDFArray(const CPDF_Array* range) {
   return reinterpret_cast<FPDF_PAGERANGE>(range);
 }
-inline CPDF_Array* CPDFArrayFromFPDFPageRange(FPDF_PAGERANGE range) {
-  return reinterpret_cast<CPDF_Array*>(range);
+inline const CPDF_Array* CPDFArrayFromFPDFPageRange(FPDF_PAGERANGE range) {
+  return reinterpret_cast<const CPDF_Array*>(range);
 }
 
 inline FPDF_PATHSEGMENT FPDFPathSegmentFromFXPathPoint(

public/fpdfview.h

diff --git a/public/fpdfview.h b/public/fpdfview.h
index 4ce6f6a..3472f58 100644
--- a/public/fpdfview.h
+++ b/public/fpdfview.h
@@ -69,7 +69,7 @@
 typedef struct fpdf_pagelink_t__* FPDF_PAGELINK;
 typedef struct fpdf_pageobject_t__* FPDF_PAGEOBJECT;  // (text, path, etc.)
 typedef struct fpdf_pageobjectmark_t__* FPDF_PAGEOBJECTMARK;
-typedef struct fpdf_pagerange_t__* FPDF_PAGERANGE;
+typedef const struct fpdf_pagerange_t__* FPDF_PAGERANGE;
 typedef const struct fpdf_pathsegment_t* FPDF_PATHSEGMENT;
 typedef void* FPDF_RECORDER;  // Passed into skia.
 typedef struct fpdf_schhandle_t__* FPDF_SCHHANDLE;