commit 69bddfee86d1b95b92413a9b8e96b3a9cca0f8e3
author Tom Sepez <tsepez@chromium.org> Mon Nov 14 20:41:50 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 14 20:41:50 2022 +0000
tree 77bc0e33818e99c4ce4e36ba59732e32c69d0166
parent b9efec82ee1ac3623fe7574591118bf2c5321a36

fix some clang-tidy member init suggestions.

Change-Id: Iebf251c519989e23a995ecf93abe008ab54b85ad
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101250
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxjs/cfx_globaldata.h

diff --git a/fxjs/cfx_globaldata.h b/fxjs/cfx_globaldata.h
index bce77db..6b94265 100644
--- a/fxjs/cfx_globaldata.h
+++ b/fxjs/cfx_globaldata.h
@@ -33,7 +33,7 @@
     ~Element();
 
     CFX_KeyValue data;
-    bool bPersistent;
+    bool bPersistent = false;
   };
 
   static CFX_GlobalData* GetRetainedInstance(Delegate* pDelegate);

fxjs/cfx_keyvalue.h

diff --git a/fxjs/cfx_keyvalue.h b/fxjs/cfx_keyvalue.h
index 97cbc1f..a6ff52a 100644
--- a/fxjs/cfx_keyvalue.h
+++ b/fxjs/cfx_keyvalue.h
@@ -28,8 +28,8 @@
   ~CFX_Value();
 
   DataType nType = DataType::kNull;
-  bool bData;
-  double dData;
+  bool bData = false;
+  double dData = 0.0;
   ByteString sData;
   std::vector<std::unique_ptr<CFX_KeyValue>> objData;
 };

fxjs/cjs_delaydata.h

diff --git a/fxjs/cjs_delaydata.h b/fxjs/cjs_delaydata.h
index 690cab8..861dbab 100644
--- a/fxjs/cjs_delaydata.h
+++ b/fxjs/cjs_delaydata.h
@@ -20,9 +20,9 @@
 
   FIELD_PROP eProp;
   int nControlIndex;
+  int32_t num = 0;
+  bool b = false;
   WideString sFieldName;
-  int32_t num;
-  bool b;
   ByteString bytestring;
   WideString widestring;
   CFX_FloatRect rect;

fxjs/cjs_global.cpp

diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index cc5997a..ffbbfcb 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -155,8 +155,8 @@
 }
 
 CJS_Global::CJS_Global(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime)
-    : CJS_Object(pObject, pRuntime) {
-  m_pGlobalData = CFX_GlobalData::GetRetainedInstance(nullptr);
+    : CJS_Object(pObject, pRuntime),
+      m_pGlobalData(CFX_GlobalData::GetRetainedInstance(nullptr)) {
   UpdateGlobalPersistentVariables();
 }