commit 6fa440ac83eb025b691bb7d3999068f6f6949a46
author Lei Zhang <thestig@chromium.org> Fri Aug 09 18:50:17 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 09 18:50:17 2024 +0000
tree 6248ba0369099cd8499a3ce91cfc550b55a6e68f
parent 72262574a6e02cd939a93a7ab7a906d4ac32eb75

Rename CPDF_ScaledRenderBuffer member variables

Use Google C++ style member variables names.

Change-Id: If40168f8975331b146c5267be59cd7b99d254f57
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/123211
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp

diff --git a/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp b/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
index b593659..5582163 100644
--- a/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
+++ b/core/fpdfapi/render/cpdf_scaledrenderbuffer.cpp
@@ -28,20 +28,21 @@
                                          const CPDF_PageObject* pObj,
                                          const CPDF_RenderOptions* pOptions,
                                          int max_dpi) {
-  m_pDevice = pDevice;
-  if (m_pDevice->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_GET_BITS)
+  device_ = pDevice;
+  if (device_->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_GET_BITS) {
     return true;
+  }
 
-  m_Rect = rect;
-  m_Matrix = CPDF_DeviceBuffer::CalculateMatrix(pDevice, rect, max_dpi,
-                                                /*scale=*/true);
-  m_pBitmapDevice = std::make_unique<CFX_DefaultRenderDevice>();
+  rect_ = rect;
+  matrix_ = CPDF_DeviceBuffer::CalculateMatrix(pDevice, rect, max_dpi,
+                                               /*scale=*/true);
+  bitmap_device_ = std::make_unique<CFX_DefaultRenderDevice>();
   bool bIsAlpha =
-      !!(m_pDevice->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_ALPHA_OUTPUT);
+      !!(device_->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_ALPHA_OUTPUT);
   FXDIB_Format dibFormat = bIsAlpha ? FXDIB_Format::kArgb : FXDIB_Format::kRgb;
   while (true) {
     FX_RECT bitmap_rect =
-        m_Matrix.TransformRect(CFX_FloatRect(rect)).GetOuterRect();
+        matrix_.TransformRect(CFX_FloatRect(rect)).GetOuterRect();
     int32_t width = bitmap_rect.Width();
     int32_t height = bitmap_rect.Height();
     // Set to 0 to make CalculatePitchAndSize() calculate it.
@@ -52,27 +53,27 @@
       return false;
 
     if (pitch_size.value().size <= kImageSizeLimitBytes &&
-        m_pBitmapDevice->Create(width, height, dibFormat)) {
+        bitmap_device_->Create(width, height, dibFormat)) {
       break;
     }
-    m_Matrix.Scale(0.5f, 0.5f);
+    matrix_.Scale(0.5f, 0.5f);
   }
-  pContext->GetBackgroundToDevice(m_pBitmapDevice.get(), pObj, pOptions,
-                                  m_Matrix);
+  pContext->GetBackgroundToDevice(bitmap_device_.get(), pObj, pOptions,
+                                  matrix_);
   return true;
 }
 
 CFX_RenderDevice* CPDF_ScaledRenderBuffer::GetDevice() const {
-  return m_pBitmapDevice ? static_cast<CFX_RenderDevice*>(m_pBitmapDevice.get())
-                         : m_pDevice.get();
+  return bitmap_device_ ? static_cast<CFX_RenderDevice*>(bitmap_device_.get())
+                        : device_.get();
 }
 
 void CPDF_ScaledRenderBuffer::OutputToDevice() {
-  if (m_pBitmapDevice) {
+  if (bitmap_device_) {
 #if defined(PDF_USE_SKIA)
-    m_pBitmapDevice->SyncInternalBitmaps();
+    bitmap_device_->SyncInternalBitmaps();
 #endif
-    m_pDevice->StretchDIBits(m_pBitmapDevice->GetBitmap(), m_Rect.left,
-                             m_Rect.top, m_Rect.Width(), m_Rect.Height());
+    device_->StretchDIBits(bitmap_device_->GetBitmap(), rect_.left, rect_.top,
+                           rect_.Width(), rect_.Height());
   }
 }

core/fpdfapi/render/cpdf_scaledrenderbuffer.h

diff --git a/core/fpdfapi/render/cpdf_scaledrenderbuffer.h b/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
index 3fb9c0b..0188343 100644
--- a/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
+++ b/core/fpdfapi/render/cpdf_scaledrenderbuffer.h
@@ -31,14 +31,14 @@
                   int max_dpi);
 
   CFX_RenderDevice* GetDevice() const;
-  const CFX_Matrix& GetMatrix() const { return m_Matrix; }
+  const CFX_Matrix& GetMatrix() const { return matrix_; }
   void OutputToDevice();
 
  private:
-  UnownedPtr<CFX_RenderDevice> m_pDevice;
-  std::unique_ptr<CFX_DefaultRenderDevice> m_pBitmapDevice;
-  FX_RECT m_Rect;
-  CFX_Matrix m_Matrix;
+  UnownedPtr<CFX_RenderDevice> device_;
+  std::unique_ptr<CFX_DefaultRenderDevice> bitmap_device_;
+  FX_RECT rect_;
+  CFX_Matrix matrix_;
 };
 
 #endif  // CORE_FPDFAPI_RENDER_CPDF_SCALEDRENDERBUFFER_H_