CHECK() device capability assumption in CPDF_ImageRenderer::NotDrawing()
Use CHECK() to assert no printer device can do blend mode.
Change-Id: Iaaf794b874fdbf63ef558e08a4935fcf572dda17
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/122450
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
diff --git a/core/fpdfapi/render/cpdf_imagerenderer.cpp b/core/fpdfapi/render/cpdf_imagerenderer.cpp
index cc7a84f..0a662a2 100644
--- a/core/fpdfapi/render/cpdf_imagerenderer.cpp
+++ b/core/fpdfapi/render/cpdf_imagerenderer.cpp
@@ -206,9 +206,14 @@
}
bool CPDF_ImageRenderer::NotDrawing() const {
- return m_pRenderStatus->IsPrint() &&
- !(m_pRenderStatus->GetRenderDevice()->GetRenderCaps() &
- FXRC_BLEND_MODE);
+ if (!m_pRenderStatus->IsPrint()) {
+ return false;
+ }
+
+ // Make sure the assumption that no printer device supports blend mode holds.
+ CHECK(
+ !(m_pRenderStatus->GetRenderDevice()->GetRenderCaps() & FXRC_BLEND_MODE));
+ return true;
}
FX_RECT CPDF_ImageRenderer::GetDrawRect() const {
