commit 773310d5aac41e6035fe117cdf853bd3dc9f4962
author Tom Sepez <tsepez@chromium.org> Fri Jun 24 22:13:38 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 24 22:13:38 2022 +0000
tree 4af0aa2d3742fdbb190972039c21e5df0f9545c1
parent 33467a6cb911cb07b50f6f3ac68e580f2d503f05

Add CPDF_Dictionary::GetMutableDirectObjectFor().

Change-Id: Ib31aa06d814d93790d7a662983aac6278aa9b738
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94671
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_editimg.cpp

diff --git a/fpdfsdk/fpdf_editimg.cpp b/fpdfsdk/fpdf_editimg.cpp
index 77bc238..8ee8b53 100644
--- a/fpdfsdk/fpdf_editimg.cpp
+++ b/fpdfsdk/fpdf_editimg.cpp
@@ -307,8 +307,9 @@
   if (!pImg)
     return 0;
 
-  CPDF_Dictionary* pDict = pImg->GetDict();
-  CPDF_Object* pFilter = pDict ? pDict->GetDirectObjectFor("Filter") : nullptr;
+  const CPDF_Dictionary* pDict = pImg->GetDict();
+  const CPDF_Object* pFilter =
+      pDict ? pDict->GetDirectObjectFor("Filter") : nullptr;
   if (!pFilter)
     return 0;
 
@@ -330,13 +331,11 @@
     return 0;
 
   CPDF_PageObject* pObj = CPDFPageObjectFromFPDFPageObject(image_object);
-  CPDF_Object* pFilter =
-      pObj->AsImage()->GetImage()->GetDict()->GetDirectObjectFor("Filter");
-  ByteString bsFilter;
-  if (pFilter->IsName())
-    bsFilter = pFilter->AsName()->GetString();
-  else
-    bsFilter = pFilter->AsArray()->GetStringAt(index);
+  const CPDF_Dictionary* pDict = pObj->AsImage()->GetImage()->GetDict();
+  const CPDF_Object* pFilter = pDict->GetDirectObjectFor("Filter");
+  ByteString bsFilter = pFilter->IsName()
+                            ? pFilter->AsName()->GetString()
+                            : pFilter->AsArray()->GetStringAt(index);
 
   return NulTerminateMaybeCopyAndReturnLength(bsFilter, buffer, buflen);
 }