commit 78ba37e7e6d958aeb1e2ea788a4625fe694d975b
author Tom Sepez <tsepez@chromium.org> Tue Nov 02 00:00:43 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 02 00:00:43 2021 +0000
tree 6f0202f8423c19aadc906fcf36228cf92280165a
parent 95e2b2bc935dcab29b2d05ddff9bb6675716f05b

Remove .c_str() from calls to  SystemFontInfoIface::GetFont().

It already takes a bytestring by const-ref, so avoid converting to
a c-style string, then implicitly allocating a new bytestring from
the c-string.

Change-Id: Ib6f48b093a39f713a4ba3a264ccbd42f5c7e278c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86711
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fxge/cfx_fontmapper.cpp

diff --git a/core/fxge/cfx_fontmapper.cpp b/core/fxge/cfx_fontmapper.cpp
index 078b213..3ec36aa 100644
--- a/core/fxge/cfx_fontmapper.cpp
+++ b/core/fxge/cfx_fontmapper.cpp
@@ -328,7 +328,7 @@
   });
 
   if (bLocalized) {
-    void* hFont = m_pFontInfo->GetFont(name.c_str());
+    void* hFont = m_pFontInfo->GetFont(name);
     if (!hFont) {
       hFont = m_pFontInfo->MapFont(0, 0, FX_Charset::kDefault, 0, name);
       if (!hFont)
@@ -605,7 +605,7 @@
       weight = old_weight;
     }
     if (!match.IsEmpty()) {
-      hFont = m_pFontInfo->GetFont(match.c_str());
+      hFont = m_pFontInfo->GetFont(match);
       if (!hFont) {
         return UseInternalSubst(pSubstFont, iBaseFont, italic_angle, old_weight,
                                 PitchFamily);
@@ -638,7 +638,7 @@
         return UseInternalSubst(pSubstFont, iBaseFont, italic_angle, old_weight,
                                 PitchFamily);
       }
-      hFont = m_pFontInfo->GetFont(it->name.c_str());
+      hFont = m_pFontInfo->GetFont(it->name);
     }
   }
   if (!hFont)