commit 792db1fee5f0a2b4cf5ffbc18f67cf20514423d3
author Andy Phan <andyphan@chromium.org> Tue Sep 17 22:53:08 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 17 22:53:08 2024 +0000
tree 0acb80d41ff973abd50571c0cdcf1f9d0623ac33
parent a78c87c672cc4d25282823338ee88d83ffc0c18a

Use EXPECT_DOUBLE_EQ in fxstring.*StringToDouble tests

Instead of using EXPECT_FLOAT_EQ, use EXPECT_DOUBLE_EQ for tests that
convert strings to doubles.

Change-Id: I36472cc5da2765cb622c1a089b561117929955ba
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/124410
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>

core/fxcrt/fx_string_unittest.cpp

diff --git a/core/fxcrt/fx_string_unittest.cpp b/core/fxcrt/fx_string_unittest.cpp
index 3d39f87..d4a7bf8 100644
--- a/core/fxcrt/fx_string_unittest.cpp
+++ b/core/fxcrt/fx_string_unittest.cpp
@@ -99,49 +99,49 @@
 }
 
 TEST(fxstring, ByteStringToDouble) {
-  EXPECT_FLOAT_EQ(0.0, StringToDouble(""));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble("0"));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble("0.0"));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble("-0.0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble(""));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble("0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble("0.0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble("-0.0"));
 
-  EXPECT_FLOAT_EQ(0.25, StringToDouble("0.25"));
-  EXPECT_FLOAT_EQ(-0.25, StringToDouble("-0.25"));
+  EXPECT_DOUBLE_EQ(0.25, StringToDouble("0.25"));
+  EXPECT_DOUBLE_EQ(-0.25, StringToDouble("-0.25"));
 
-  EXPECT_FLOAT_EQ(100.0, StringToDouble("100"));
-  EXPECT_FLOAT_EQ(100.0, StringToDouble("100.0"));
-  EXPECT_FLOAT_EQ(100.0, StringToDouble("    100.0"));
-  EXPECT_FLOAT_EQ(-100.0, StringToDouble("-100.0000"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble("100"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble("100.0"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble("    100.0"));
+  EXPECT_DOUBLE_EQ(-100.0, StringToDouble("-100.0000"));
 
-  EXPECT_FLOAT_EQ(3.402823e+38,
-                  StringToDouble("340282300000000000000000000000000000000"));
-  EXPECT_FLOAT_EQ(-3.402823e+38,
-                  StringToDouble("-340282300000000000000000000000000000000"));
+  EXPECT_DOUBLE_EQ(3.402823e+38,
+                   StringToDouble("340282300000000000000000000000000000000"));
+  EXPECT_DOUBLE_EQ(-3.402823e+38,
+                   StringToDouble("-340282300000000000000000000000000000000"));
 
-  EXPECT_FLOAT_EQ(1.000000119, StringToDouble("1.000000119"));
-  EXPECT_FLOAT_EQ(1.999999881, StringToDouble("1.999999881"));
+  EXPECT_DOUBLE_EQ(1.000000119, StringToDouble("1.000000119"));
+  EXPECT_DOUBLE_EQ(1.999999881, StringToDouble("1.999999881"));
 }
 
 TEST(fxstring, WideStringToDouble) {
-  EXPECT_FLOAT_EQ(0.0, StringToDouble(L""));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble(L"0"));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble(L"0.0"));
-  EXPECT_FLOAT_EQ(0.0, StringToDouble(L"-0.0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble(L""));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble(L"0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble(L"0.0"));
+  EXPECT_DOUBLE_EQ(0.0, StringToDouble(L"-0.0"));
 
-  EXPECT_FLOAT_EQ(0.25, StringToDouble(L"0.25"));
-  EXPECT_FLOAT_EQ(-0.25, StringToDouble(L"-0.25"));
+  EXPECT_DOUBLE_EQ(0.25, StringToDouble(L"0.25"));
+  EXPECT_DOUBLE_EQ(-0.25, StringToDouble(L"-0.25"));
 
-  EXPECT_FLOAT_EQ(100.0, StringToDouble(L"100"));
-  EXPECT_FLOAT_EQ(100.0, StringToDouble(L"100.0"));
-  EXPECT_FLOAT_EQ(100.0, StringToDouble(L"    100.0"));
-  EXPECT_FLOAT_EQ(-100.0, StringToDouble(L"-100.0000"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble(L"100"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble(L"100.0"));
+  EXPECT_DOUBLE_EQ(100.0, StringToDouble(L"    100.0"));
+  EXPECT_DOUBLE_EQ(-100.0, StringToDouble(L"-100.0000"));
 
-  EXPECT_FLOAT_EQ(3.402823e+38,
-                  StringToDouble(L"340282300000000000000000000000000000000"));
-  EXPECT_FLOAT_EQ(-3.402823e+38,
-                  StringToDouble(L"-340282300000000000000000000000000000000"));
+  EXPECT_DOUBLE_EQ(3.402823e+38,
+                   StringToDouble(L"340282300000000000000000000000000000000"));
+  EXPECT_DOUBLE_EQ(-3.402823e+38,
+                   StringToDouble(L"-340282300000000000000000000000000000000"));
 
-  EXPECT_FLOAT_EQ(1.000000119, StringToDouble(L"1.000000119"));
-  EXPECT_FLOAT_EQ(1.999999881, StringToDouble(L"1.999999881"));
+  EXPECT_DOUBLE_EQ(1.000000119, StringToDouble(L"1.000000119"));
+  EXPECT_DOUBLE_EQ(1.999999881, StringToDouble(L"1.999999881"));
 }
 
 TEST(fxstring, SplitByteString) {