Reorder FPDF_AVAIL members in EmbedderTest.
The member variable ordering goes against the comments, which indicate
the ordering should be reversed. Also switch to using tickmarks in the
comments in this part of the file.
Change-Id: Id01d9bc1d205f92c6ea6904aa1c816eb26c961f4
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86870
Reviewed-by: Hui Yingst <nigi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index 2242355..a1b0630 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -276,9 +276,9 @@
FPDF_DOCUMENT document_ = nullptr;
FPDF_FORMHANDLE form_handle_ = nullptr;
+ FPDF_FILEACCESS file_access_; // must outlive `avail_`.
+ std::unique_ptr<FakeFileAccess> fake_file_access_; // must outlive `avail_`.
FPDF_AVAIL avail_ = nullptr;
- FPDF_FILEACCESS file_access_; // must outlive |avail_|.
- std::unique_ptr<FakeFileAccess> fake_file_access_; // must outlive |avail_|.
std::unique_ptr<TestLoader> loader_;
size_t file_length_ = 0;
@@ -287,10 +287,10 @@
FPDF_DOCUMENT saved_document_ = nullptr;
FPDF_FORMHANDLE saved_form_handle_ = nullptr;
- FPDF_AVAIL saved_avail_ = nullptr;
- FPDF_FILEACCESS saved_file_access_; // must outlive |saved_avail_|.
- // must outlive |saved_avail_|.
+ FPDF_FILEACCESS saved_file_access_; // must outlive `saved_avail_`.
+ // must outlive `saved_avail_`.
std::unique_ptr<FakeFileAccess> saved_fake_file_access_;
+ FPDF_AVAIL saved_avail_ = nullptr;
PageNumberToHandleMap saved_page_map_;
private:
