commit 8739c4c6f05650cc0447c70e350b5dbfd7605d2d
author Tom Sepez <tsepez@chromium.org> Tue Jun 27 18:13:13 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 27 18:13:13 2023 +0000
tree 97adc1e447d3448bab402357c81a25457c5f3ba3
parent 5b115ea3f57135a780443fd9a9bc0ff0b71ab14c

Fix millisecond check in IsIsoTimeFormat()

Missing zero in constant 1000.

-- Tidy initialization while at it.

Change-Id: I94522738a486460105a5ceac7120f980cd37d4ba
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/109070
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxjs/xfa/cfxjse_formcalc_context.cpp

diff --git a/fxjs/xfa/cfxjse_formcalc_context.cpp b/fxjs/xfa/cfxjse_formcalc_context.cpp
index fab90c5..04cbecd 100644
--- a/fxjs/xfa/cfxjse_formcalc_context.cpp
+++ b/fxjs/xfa/cfxjse_formcalc_context.cpp
@@ -658,17 +658,15 @@
       return false;
 
     ++iIndex;
-    char szMilliSeconds[kSubSecondLength + 1];
+    char szMilliSeconds[kSubSecondLength + 1] = {};
     for (int j = 0; j < kSubSecondLength; ++j) {
       char c = pData[iIndex + j];
       if (!isdigit(c))
         return false;
       szMilliSeconds[j] = c;
     }
-    szMilliSeconds[kSubSecondLength] = '\0';
-
     iMilliSecond = FXSYS_atoi(szMilliSeconds);
-    if (iMilliSecond > 100) {
+    if (iMilliSecond >= 1000) {
       iMilliSecond = 0;
       return false;
     }