commit 8807a9a257552fb2f2858434c5c88de625cf6dfd
author Tom Sepez <tsepez@chromium.org> Mon Aug 08 17:56:24 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 08 17:56:24 2022 +0000
tree d3f2258be5a91779b96ad5ec635bfe2e1a5367af
parent 965b93627f95af5026cad265b3345ea2908755cb

Pass retained argument to CPDF_PageRenderCache::ResetBitmapForImage()

Bug: pdfium:1843
Change-Id: I8b76141d7eca10744c4cc06ef421fa5590f2b940
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/96190
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/page/cpdf_image.cpp

diff --git a/core/fpdfapi/page/cpdf_image.cpp b/core/fpdfapi/page/cpdf_image.cpp
index 0fbe736..19d2bf9 100644
--- a/core/fpdfapi/page/cpdf_image.cpp
+++ b/core/fpdfapi/page/cpdf_image.cpp
@@ -326,7 +326,7 @@
 
 void CPDF_Image::ResetCache(CPDF_Page* pPage) {
   RetainPtr<CPDF_Image> pHolder(this);
-  pPage->GetRenderCache()->ResetBitmapForImage(pHolder);
+  pPage->GetRenderCache()->ResetBitmapForImage(std::move(pHolder));
 }
 
 RetainPtr<CFX_DIBBase> CPDF_Image::LoadDIBBase() const {

core/fpdfapi/page/cpdf_page.h

diff --git a/core/fpdfapi/page/cpdf_page.h b/core/fpdfapi/page/cpdf_page.h
index 4214ce6..2b6514e 100644
--- a/core/fpdfapi/page/cpdf_page.h
+++ b/core/fpdfapi/page/cpdf_page.h
@@ -39,7 +39,7 @@
   class RenderCacheIface {
    public:
     virtual ~RenderCacheIface() = default;
-    virtual void ResetBitmapForImage(const RetainPtr<CPDF_Image>& pImage) = 0;
+    virtual void ResetBitmapForImage(RetainPtr<CPDF_Image> pImage) = 0;
   };
 
   class RenderContextClearer {

core/fpdfapi/render/cpdf_pagerendercache.cpp

diff --git a/core/fpdfapi/render/cpdf_pagerendercache.cpp b/core/fpdfapi/render/cpdf_pagerendercache.cpp
index 60060b5..956f2fe 100644
--- a/core/fpdfapi/render/cpdf_pagerendercache.cpp
+++ b/core/fpdfapi/render/cpdf_pagerendercache.cpp
@@ -116,8 +116,7 @@
   return false;
 }
 
-void CPDF_PageRenderCache::ResetBitmapForImage(
-    const RetainPtr<CPDF_Image>& pImage) {
+void CPDF_PageRenderCache::ResetBitmapForImage(RetainPtr<CPDF_Image> pImage) {
   CPDF_ImageCacheEntry* pEntry;
   const CPDF_Stream* pStream = pImage->GetStream();
   const auto it = m_ImageCache.find(pStream);

core/fpdfapi/render/cpdf_pagerendercache.h

diff --git a/core/fpdfapi/render/cpdf_pagerendercache.h b/core/fpdfapi/render/cpdf_pagerendercache.h
index b2cbc16..6270964 100644
--- a/core/fpdfapi/render/cpdf_pagerendercache.h
+++ b/core/fpdfapi/render/cpdf_pagerendercache.h
@@ -30,7 +30,7 @@
   ~CPDF_PageRenderCache() override;
 
   // CPDF_Page::RenderCacheIface:
-  void ResetBitmapForImage(const RetainPtr<CPDF_Image>& pImage) override;
+  void ResetBitmapForImage(RetainPtr<CPDF_Image> pImage) override;
 
   void CacheOptimization(int32_t dwLimitCacheSize);
   uint32_t GetTimeCount() const { return m_nTimeCount; }