commit 890eac2b7fd1764f4cc9ced92872fd36226802c3
author Tom Sepez <tsepez@chromium.org> Mon Dec 03 20:35:51 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Dec 03 20:35:51 2018 +0000
tree 31a2e129a221a19036a24fb0906ba0bcaa0d1fab
parent 92ea923a5a7b5dd96d7041ca35da01d04a23b29b

Prefer WideString() over L"".

Although longer in the source code, this avoids creating a literal
somewhere and supplying it's address as an argument to an implicit
constructor. I believe blink did something similar a long time ago
with its string usage.

Change-Id: I7879ceb9a706e762df324718af194e97ed6db858
Reviewed-on: https://pdfium-review.googlesource.com/c/46350
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
index 3260908..68f5a67 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
@@ -452,7 +452,7 @@
     const WideString& wsEncode,
     const WideString& wsHeader) {
   if (!m_pInfo || !m_pInfo->FFI_PostRequestURL)
-    return L"";
+    return WideString();
 
   ByteString bsURL = wsURL.ToUTF16LE();
   ByteString bsData = wsData.ToUTF16LE();