commit 898c5e841d074efae73a86f47881e57a3a630e74
author Lei Zhang <thestig@chromium.org> Thu Nov 10 03:04:58 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 10 03:04:58 2022 +0000
tree 8dd37d1796ed8fa67427131b0182bdf5da9e6190
parent 4fbd4ab674fc59cce1852d9ae517d89148bf01f9

Remove dead code in CBC_OneDimWriter::RenderResult().

A conditional in RenderResult() evaluates to (false && true), so it's
just dead code. Then RenderVerticalBars() only has a single caller and
can be folded into RenderResult().

Change-Id: I2c9a30dfbb89c6717aaaea0d3efd5d086ea2597e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100971
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxbarcode/oned/BC_OneDimWriter.cpp

diff --git a/fxbarcode/oned/BC_OneDimWriter.cpp b/fxbarcode/oned/BC_OneDimWriter.cpp
index dc39f5d..050657a 100644
--- a/fxbarcode/oned/BC_OneDimWriter.cpp
+++ b/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -279,20 +279,8 @@
     if (outputX >= outputWidth)
       return true;
 
-    if (outputX + 1 > outputWidth && outputWidth - outputX > 0) {
-      RenderVerticalBars(outputX, outputWidth - outputX);
-      return true;
-    }
-
-    RenderVerticalBars(outputX, /*width=*/1);
+    m_output.emplace_back();
+    m_output.back().AppendRect(outputX, 0.0f, outputX + 1, 1.0f);
   }
   return true;
 }
-
-void CBC_OneDimWriter::RenderVerticalBars(int32_t outputX, int32_t width) {
-  for (int i = 0; i < width; ++i) {
-    float x = outputX + i;
-    m_output.emplace_back();
-    m_output.back().AppendRect(x, 0.0f, x + 1, 1.0f);
-  }
-}

fxbarcode/oned/BC_OneDimWriter.h

diff --git a/fxbarcode/oned/BC_OneDimWriter.h b/fxbarcode/oned/BC_OneDimWriter.h
index efe43d4..6ae1475 100644
--- a/fxbarcode/oned/BC_OneDimWriter.h
+++ b/fxbarcode/oned/BC_OneDimWriter.h
@@ -78,8 +78,6 @@
                         int32_t patternLength,
                         bool startColor);
 
-  void RenderVerticalBars(int32_t outputX, int32_t width);
-
   bool m_bPrintChecksum = true;
   bool m_bCalcChecksum = false;
   bool m_bLeftPadding = false;