commit 8a185fa43a49ada87b27d8a8215af909c4e057d1
author Tom Sepez <tsepez@chromium.org> Mon Sep 26 18:33:13 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 26 18:33:13 2022 +0000
tree f678dec26da8f262af32a054b81087803f9f93e4
parent 9f7dcae9390aa623cffb60002628bdfe5876512f

Return retained objects from CPDF_Image and CPDF_Page methods.

Change-Id: Ifa5a6708a18a68bc9a1557786b7da88f458b9dc0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/98470
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_editimg.cpp

diff --git a/fpdfsdk/fpdf_editimg.cpp b/fpdfsdk/fpdf_editimg.cpp
index f4378a9..3c41243 100644
--- a/fpdfsdk/fpdf_editimg.cpp
+++ b/fpdfsdk/fpdf_editimg.cpp
@@ -312,7 +312,7 @@
   if (!pImg)
     return 0;
 
-  const CPDF_Dictionary* pDict = pImg->GetDict();
+  RetainPtr<const CPDF_Dictionary> pDict = pImg->GetDict();
   if (!pDict)
     return 0;
 
@@ -338,7 +338,8 @@
     return 0;
 
   CPDF_PageObject* pObj = CPDFPageObjectFromFPDFPageObject(image_object);
-  const CPDF_Dictionary* pDict = pObj->AsImage()->GetImage()->GetDict();
+  RetainPtr<const CPDF_Dictionary> pDict =
+      pObj->AsImage()->GetImage()->GetDict();
   RetainPtr<const CPDF_Object> pFilter = pDict->GetDirectObjectFor("Filter");
   ByteString bsFilter = pFilter->IsName()
                             ? pFilter->AsName()->GetString()