commit 8d7ab32f5e928b528fc5b0d1e844ed43673cf341
author Lei Zhang <thestig@chromium.org> Thu Oct 19 20:23:48 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 19 20:23:48 2023 +0000
tree 7998af55e8579a089a31470ea6f07550cf7dd30d
parent 0bb4790a4455400532900b350d967260fa1ea552

Skia: Disable legacy APIs

Make //skia/BUILD.gn consistent with Chromium's //skia/BUILD.gn. Disable
various legacy Skia APIs to ensure PDFium does not accidentally use
them.

Change-Id: I95f6983859a9260aa8dffd0824e69dcd2b78c503
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/112870
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

skia/BUILD.gn

diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index 4a0f3e6..79b1d86 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -27,6 +27,24 @@
   defines = [
     "SK_ENCODE_PNG",
     "SK_USER_CONFIG_HEADER=\"../../skia/config/SkPdfiumUserConfig.h\"",
+    "SK_DISABLE_LEGACY_SKSURFACE_METHODS",
+    "SK_DISABLE_LEGACY_GRAPHITE_IMAGE_FACTORIES",
+    "SK_DISABLE_LEGACY_GRAPHITE_IMAGE_METHODS",
+    "SK_DISABLE_LEGACY_SKSURFACE_FACTORIES",
+    "SK_DISABLE_LEGACY_SKSURFACE_FLUSH",
+    "SK_DISABLE_LEGACY_SKSURFACE_AS_IMAGE",
+    "SK_DISABLE_LEGACY_SKSURFACE_DISPLAYLIST",
+    "SK_DISABLE_LEGACY_IMAGE_SUBSET_METHODS",
+    "SK_DISABLE_LEGACY_IMAGE_COLORSPACE_METHODS",
+    "SK_DISABLE_LEGACY_IMAGE_RELEASE_PROCS",
+    "SK_DISABLE_LEGACY_GL_BACKEND_SURFACE",
+    "SK_DISABLE_LEGACY_INIT_DECODERS",
+    "SK_DISABLE_LEGACY_GRDIRECTCONTEXT_FLUSH",
+    "SK_DISABLE_LEGACY_GRDIRECTCONTEXT_BOOLS",
+    "SK_DISABLE_LEGACY_GL_GRDIRECTCONTEXT_FACTORIES",
+    "SK_DISABLE_LEGACY_PNG_WRITEBUFFER",
+    "SK_SLUG_DISABLE_LEGACY_DESERIALIZE",
+    "SK_DISABLE_LEGACY_VK_GRDIRECTCONTEXT_FACTORIES",
   ]
 
   if (is_win) {