commit 8e626f4ab3bc6a683c18895399403752c77a54ab
author Lei Zhang <thestig@chromium.org> Tue Feb 11 14:12:38 2025 -0800
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 11 14:12:38 2025 -0800
tree f2ae586e07943769cdb59ca65ba2eb4b02cfccf6
parent dc0653ef3e7e8ee70af14dea790aba72d72ff2ca

Call FPDFText_GetCharBox() in FPDFTextEmbedderTest.TextVertical

Add FPDFText_GetCharBox() calls so there is a point of comparison for
the FPDFText_GetLooseCharBox() calls. Now it is easier to see the
FPDFText_GetLooseCharBox() results have top/bottom flipped.

Bug: 395836304
Change-Id: I9944a15d5a0c10543517045a15bccd1988a2f2fb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128750
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_text_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_text_embeddertest.cpp b/fpdfsdk/fpdf_text_embeddertest.cpp
index c141aec..0a4fa04 100644
--- a/fpdfsdk/fpdf_text_embeddertest.cpp
+++ b/fpdfsdk/fpdf_text_embeddertest.cpp
@@ -301,6 +301,39 @@
   EXPECT_NEAR(8.668, x, 0.001);
   EXPECT_NEAR(160.492, y, 0.001);
 
+  double left;
+  double right;
+  double bottom;
+  double top;
+  EXPECT_TRUE(
+      FPDFText_GetCharBox(textpage.get(), 1, &left, &right, &bottom, &top));
+#if BUILDFLAG(IS_MAC)
+  EXPECT_NEAR(7.168, left, 0.001);
+#else
+  EXPECT_NEAR(7.276, left, 0.001);
+#endif
+  EXPECT_NEAR(12.808, right, 0.001);
+#if BUILDFLAG(IS_MAC)
+  EXPECT_NEAR(171.4, bottom, 0.001);
+  EXPECT_NEAR(178.06, top, 0.001);
+#else
+  EXPECT_NEAR(171.364, bottom, 0.001);
+  EXPECT_NEAR(178.288, top, 0.001);
+#endif
+  EXPECT_TRUE(
+      FPDFText_GetCharBox(textpage.get(), 2, &left, &right, &bottom, &top));
+#if BUILDFLAG(IS_MAC)
+  EXPECT_NEAR(9.472, left, 0.001);
+  EXPECT_NEAR(10.528, right, 0.001);
+  EXPECT_NEAR(160.492, bottom, 0.001);
+  EXPECT_NEAR(169.324, top, 0.001);
+#else
+  EXPECT_NEAR(9.772, left, 0.001);
+  EXPECT_NEAR(11.56, right, 0.001);
+  EXPECT_NEAR(160.348, bottom, 0.001);
+  EXPECT_NEAR(170.188, top, 0.001);
+#endif
+
   FS_RECTF rect;
   EXPECT_TRUE(FPDFText_GetLooseCharBox(textpage.get(), 1, &rect));
   EXPECT_NEAR(4, rect.left, 0.001);