commit 937e7c8480f329b2e6ac6238d696822f0cb97a27
author K. Moon <kmoon@chromium.org> Mon Jun 05 19:45:45 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 05 19:45:45 2023 +0000
tree ee673dcbb50ce528d0b5cf80de13419ef64fadbe
parent d2dcc316e6f5c52dba22b3340d5cce53ad01d21b

Tighten DEPS rules for Skia headers

Makes DEPS rules referencing third_party/skia/include stricter. In
particular, files outside of //core/fxge/skia now use
specific_include_rules instead of include_rules.

Bug: pdfium:2046
Change-Id: I49d2a6ad8e5adf19938ec0b351ae73f9809f04cd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/108430
Commit-Queue: Nigi <nigi@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Auto-Submit: K. Moon <kmoon@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

core/fxge/DEPS

diff --git a/core/fxge/DEPS b/core/fxge/DEPS
index 6492756..8586210 100644
--- a/core/fxge/DEPS
+++ b/core/fxge/DEPS
@@ -1,3 +1,5 @@
-include_rules = [
-  '+third_party/skia/include'
-]
+specific_include_rules = {
+  'cfx_glyphcache\.(cpp|h)|cfx_renderdevice\.cpp': [
+    '+third_party/skia/include',
+  ],
+}

core/fxge/skia/DEPS

diff --git a/core/fxge/skia/DEPS b/core/fxge/skia/DEPS
index 17c0265..9927648 100644
--- a/core/fxge/skia/DEPS
+++ b/core/fxge/skia/DEPS
@@ -1,5 +1,9 @@
 include_rules = [
-  '+fpdfsdk',
-  '+public',
   '+third_party/skia/include',
 ]
+
+specific_include_rules = {
+  'fx_skia_device_embeddertest.cpp': [
+    '+fpdfsdk',
+  ]
+}

fpdfsdk/DEPS

diff --git a/fpdfsdk/DEPS b/fpdfsdk/DEPS
index 14d2700..7bcf89b 100644
--- a/fpdfsdk/DEPS
+++ b/fpdfsdk/DEPS
@@ -2,10 +2,15 @@
   '+core',
   '+fxjs',
   '+public',
-  '+third_party/skia/include',
   '+v8',
   '+xfa/fgas/font',
   '+xfa/fgas/graphics',
   '+xfa/fwl',
   '+xfa/fxfa',
 ]
+
+specific_include_rules = {
+  'fpdf_formfill\.cpp|fpdf_view(_embeddertest)?\.cpp': [
+    '+third_party/skia/include',
+  ],
+}