commit 956553e715787cfc4dd8423d5e9a04a0131878c3
author jaepark <jaepark@google.com> Wed Aug 31 06:49:27 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 31 06:49:27 2016 -0700
tree 08622d504322d5dae37b5bb5025a90c81ebdee6b
parent 87dffc0315477150c9c1964913b65bc97bdf654f

Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.

Review-Url: https://codereview.chromium.org/2295953002

fpdfsdk/cpdfsdk_annot.cpp

diff --git a/fpdfsdk/cpdfsdk_annot.cpp b/fpdfsdk/cpdfsdk_annot.cpp
index 5ca439d..59d8f24 100644
--- a/fpdfsdk/cpdfsdk_annot.cpp
+++ b/fpdfsdk/cpdfsdk_annot.cpp
@@ -58,8 +58,8 @@
   return nullptr;
 }
 
-CFX_ByteString CPDFSDK_Annot::GetAnnotSubtype() const {
-  return "";
+CPDF_Annot::Subtype CPDFSDK_Annot::GetAnnotSubtype() const {
+  return CPDF_Annot::Subtype::UNKNOWN;
 }
 
 bool CPDFSDK_Annot::IsSignatureWidget() const {