commit ab00c1bc9da3cc486ccd58f46306f80abeb37f02
author Lei Zhang <thestig@chromium.org> Thu Mar 23 17:06:16 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 23 17:06:16 2023 +0000
tree d8080b50d053851330de19f691d105dfa2ada472
parent a066864b6e4f48f013204605bbb52dfcc28d0ee6

Use SkPackARGB32NoCheck() instead of SkPackARGB32()

Since the alpha value is hard coded to 0xFF, the check always passes.

Change-Id: I2c88f34d5a59b1e3ed33e24a846e33f8b852d898
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/105411
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>

core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 0abf7a7..602ef33 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -420,9 +420,9 @@
       float_colors[j] =
           colors_min[j] + (colors_max[j] - colors_min[j]) * interp;
     }
-    colors.push_back(SkPackARGB32(0xFF, FloatToByte(float_colors[0]),
-                                  FloatToByte(float_colors[1]),
-                                  FloatToByte(float_colors[2])));
+    colors.push_back(SkPackARGB32NoCheck(0xFF, FloatToByte(float_colors[0]),
+                                         FloatToByte(float_colors[1]),
+                                         FloatToByte(float_colors[2])));
     pos.push_back(static_cast<float>(i) / (sample_count - 1));
   }
   return true;
@@ -742,8 +742,8 @@
             static_cast<const uint8_t*>(buffer) + y * rowBytes;
         pdfium::span<uint32_t> dst_row = dst32_pixels.subspan(y * width);
         for (int x = 0; x < width; ++x) {
-          dst_row[x] = SkPackARGB32(0xFF, srcRow[x * 3 + 2], srcRow[x * 3 + 1],
-                                    srcRow[x * 3 + 0]);
+          dst_row[x] = SkPackARGB32NoCheck(
+              0xFF, srcRow[x * 3 + 2], srcRow[x * 3 + 1], srcRow[x * 3 + 0]);
         }
       }
       rowBytes = width * sizeof(uint32_t);