commit b4126559ec6112dba01254198d532bc26687023c
author Hui Yingst <nigi@chromium.org> Thu Jul 07 23:48:02 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 07 23:48:02 2022 +0000
tree 32b4df58fe5b01eb84198496b2821e93b102df37
parent 8aa38e752cd2a530a01409087b06f79e05cb74ea

Enable an embedder test for SkiaPaths.

The SkiaPaths rendering result (See [1]) is acceptable for test
FPDFProgressiveRenderEmbedderTest.
RenderHighlightWithColorSchemeAndConvertFillToStroke. This CL updates
the SkiaPaths expectation for this test so that it can pass and update
the bug number for the existing Skia issue.

[1] https://crbug.com/pdfium/1500#c102

Bug: pdfium:1500
Change-Id: I9a82f649662ed72b797c8f46011f2561650b1416
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/95030
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>

core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp

diff --git a/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp b/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
index 3427fb1..12ccc43 100644
--- a/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
+++ b/core/fpdfapi/render/fpdf_progressive_render_embeddertest.cpp
@@ -401,8 +401,8 @@
                                  kContentWithHighlightFillChecksum);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
-#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+// TODO(crbug.com/pdfium/1847): Fix this test and enable.
+#if defined(_SKIA_SUPPORT_)
 #define MAYBE_RenderHighlightWithColorSchemeAndConvertFillToStroke \
   DISABLED_RenderHighlightWithColorSchemeAndConvertFillToStroke
 #else
@@ -417,13 +417,19 @@
   // Note: The stroke color rendered for highlight is different from the normal
   // path since highlights have Multiply blend mode, while the other path has
   // Normal blend mode.
+
+#if defined(_SKIA_SUPPORT_PATHS_)
+  static constexpr char kMD5ContentWithHighlight[] =
+      "eff6eef2409ef5fbf4612bf6af42e0a0";
+#else
 #if BUILDFLAG(IS_APPLE)
   static constexpr char kMD5ContentWithHighlight[] =
       "8837bea0b3520164b1784e513c882a2d";
 #else
   static constexpr char kMD5ContentWithHighlight[] =
       "3dd8c02f5c06bac85e0d2c8bf37d1dc4";
-#endif
+#endif  // BUILDFLAG(IS_APPLE)
+#endif  // defined(_SKIA_SUPPORT_PATHS_)
 
   ASSERT_TRUE(OpenDocument("annotation_highlight_square_with_ap.pdf"));