commit b4958712e5d7ad9e475ac228880a4d98c4b612a7
author Tom Sepez <tsepez@chromium.org> Tue Oct 13 20:30:43 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Oct 13 20:30:43 2020 +0000
tree 2945557a920b2d3316ae445473cfe5a2c4f47f2f
parent 4affe8bcc1153e23c95b0a94da790c7927fea896

Make CJS_Object's ObjDefnID be one-based.

Then use 0 as the invalid object id instead of -1.
Then stop shipping about 80 bytes of "-1" as mutable data, since
zero-initialized .bss doesn't cost anything size-wise.

Change-Id: I79956d85e0e2114038d6f67e11954451097d7d19
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/74970
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/cjs_event.h

diff --git a/fxjs/cjs_event.h b/fxjs/cjs_event.h
index b2fa4dc..d2147cf 100644
--- a/fxjs/cjs_event.h
+++ b/fxjs/cjs_event.h
@@ -12,7 +12,7 @@
 
 class CJS_Event final : public CJS_Object {
  public:
-  static int GetObjDefnID();
+  static uint32_t GetObjDefnID();
   static void DefineJSObjects(CFXJS_Engine* pEngine);
 
   CJS_Event(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime);
@@ -40,7 +40,7 @@
   JS_STATIC_PROP(willCommit, will_commit, CJS_Event)
 
  private:
-  static int ObjDefnID;
+  static uint32_t ObjDefnID;
   static const char kName[];
   static const JSPropertySpec PropertySpecs[];