commit b5699d85f1b25ddc3070db400943b75ced309f75
author Tom Sepez <tsepez@chromium.org> Fri Aug 27 18:40:17 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 27 18:40:17 2021 +0000
tree fe9c9564362aed06d72b19ee711a6bcd903fee00
parent 6d4d9ca36cf7a227fa8ec61bed28dfc3dd0da520

Remove unused argument from CXFA_DocumentBuilder::DataLoader()

-- slight re-ordering in .h file to match .cpp order.

Change-Id: Id1961b0fb71e05c21722085cb8a87bbf17a4ade9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84510
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fxfa/parser/cxfa_document_builder.cpp

diff --git a/xfa/fxfa/parser/cxfa_document_builder.cpp b/xfa/fxfa/parser/cxfa_document_builder.cpp
index 034760f..36bafa2 100644
--- a/xfa/fxfa/parser/cxfa_document_builder.cpp
+++ b/xfa/fxfa/parser/cxfa_document_builder.cpp
@@ -282,7 +282,7 @@
       }
       root_node_ = pXFANode;
     } else {
-      root_node_ = DataLoader(pXFANode, pXMLNode, true);
+      root_node_ = DataLoader(pXFANode, pXMLNode);
     }
   } else if (pXFANode->IsContentNode()) {
     ParseContentNode(pXFANode, pXMLNode, ePacketID);
@@ -537,7 +537,7 @@
 
     pNode->JSObject()->SetCData(XFA_Attribute::Name,
                                 WideString::FromASCII(packet.name));
-    if (!DataLoader(pNode, pDatasetsXMLNode, false))
+    if (!DataLoader(pNode, pDatasetsXMLNode))
       return nullptr;
 
     pNode->SetXMLMappingNode(pDatasetsXMLNode);
@@ -570,7 +570,7 @@
 
   WideString wsLocalName = ToXMLElement(pDataXMLNode)->GetLocalTagName();
   pNode->JSObject()->SetCData(XFA_Attribute::Name, wsLocalName);
-  if (!DataLoader(pNode, pDataXMLNode, true))
+  if (!DataLoader(pNode, pDataXMLNode))
     return nullptr;
 
   pNode->SetXMLMappingNode(pDataXMLNode);
@@ -629,8 +629,7 @@
 }
 
 CXFA_Node* CXFA_DocumentBuilder::DataLoader(CXFA_Node* pXFANode,
-                                            CFX_XMLNode* pXMLDoc,
-                                            bool bDoTransform) {
+                                            CFX_XMLNode* pXMLDoc) {
   ParseDataGroup(pXFANode, pXMLDoc, XFA_PacketType::Datasets);
   return pXFANode;
 }

xfa/fxfa/parser/cxfa_document_builder.h

diff --git a/xfa/fxfa/parser/cxfa_document_builder.h b/xfa/fxfa/parser/cxfa_document_builder.h
index df309e0..e07dfb0 100644
--- a/xfa/fxfa/parser/cxfa_document_builder.h
+++ b/xfa/fxfa/parser/cxfa_document_builder.h
@@ -44,13 +44,11 @@
       XFA_Element element);
   CXFA_Node* ParseAsXDPPacket_Xdc(CFX_XMLNode* pXMLDocumentNode);
   CXFA_Node* ParseAsXDPPacket_User(CFX_XMLNode* pXMLDocumentNode);
+  CXFA_Node* DataLoader(CXFA_Node* pXFANode, CFX_XMLNode* pXMLDoc);
   CXFA_Node* NormalLoader(CXFA_Node* pXFANode,
                           CFX_XMLNode* pXMLDoc,
                           XFA_PacketType ePacketID,
                           bool bUseAttribute);
-  CXFA_Node* DataLoader(CXFA_Node* pXFANode,
-                        CFX_XMLNode* pXMLDoc,
-                        bool bDoTransform);
   void ParseContentNode(CXFA_Node* pXFANode,
                         CFX_XMLNode* pXMLNode,
                         XFA_PacketType ePacketID);