commit bce7ccbf77843a8e94148c360db5fbf71f36267f
author Lei Zhang <thestig@chromium.org> Mon Apr 28 17:08:00 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 28 17:08:00 2025 -0700
tree 6eea9291b9b56ff75864d487bb33d6ad4a53618e
parent 87a497287e02ba8cfa61418c2443e205d5b7e054

Use size_t for indices in CPDF_CMap::GetNextChar()

No need to cast.

Change-Id: I01d75242f552afa36c27bd7953e98040a085635e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/130992
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/font/cpdf_cmap.cpp

diff --git a/core/fpdfapi/font/cpdf_cmap.cpp b/core/fpdfapi/font/cpdf_cmap.cpp
index e33c768..710b3f6 100644
--- a/core/fpdfapi/font/cpdf_cmap.cpp
+++ b/core/fpdfapi/font/cpdf_cmap.cpp
@@ -353,18 +353,18 @@
     }
     case MixedFourBytes: {
       std::array<uint8_t, 4> codes;
-      int char_size = 1;
+      size_t char_size = 1;
       codes[0] = offset < pBytes.size() ? pBytes[offset++] : 0;
       while (true) {
-        int ret = CheckFourByteCodeRange(
-            pdfium::make_span(codes).first(static_cast<size_t>(char_size)),
-            mixed_four_byte_leading_ranges_);
+        int ret =
+            CheckFourByteCodeRange(pdfium::make_span(codes).first(char_size),
+                                   mixed_four_byte_leading_ranges_);
         if (ret == 0) {
           return 0;
         }
         if (ret == 2) {
           uint32_t charcode = 0;
-          for (int i = 0; i < char_size; i++) {
+          for (size_t i = 0; i < char_size; i++) {
             charcode = (charcode << 8) + codes[i];
           }
           return charcode;