commit bd4515474a356c1eeda7229627dafc01a76423a1
author Lei Zhang <thestig@chromium.org> Tue Jul 18 18:01:51 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 18 18:01:51 2023 +0000
tree 386ec5d9b7a50ac5d3af908484ee29c70c5f4149
parent d4ae8a23620b1988da5e896d7b1b2fb7873d386c

Switch to NOTREACHED_NORETURN() in fxbarcode

Switch from NOTREACHED() to NOTREACHED_NORETURN().

Bug: pdfium:2008
Change-Id: If730158598e73832e35e9293e74d7395952aca73
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/109870
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxbarcode/cfx_barcode.cpp

diff --git a/fxbarcode/cfx_barcode.cpp b/fxbarcode/cfx_barcode.cpp
index f7cd5f6..cc7fab2 100644
--- a/fxbarcode/cfx_barcode.cpp
+++ b/fxbarcode/cfx_barcode.cpp
@@ -50,8 +50,7 @@
     case BC_TYPE::kUnknown:
       return nullptr;
   }
-  NOTREACHED();
-  return nullptr;
+  NOTREACHED_NORETURN();
 }
 
 }  // namespace

fxbarcode/datamatrix/BC_SymbolInfo.cpp

diff --git a/fxbarcode/datamatrix/BC_SymbolInfo.cpp b/fxbarcode/datamatrix/BC_SymbolInfo.cpp
index 05efd56..59d40d0 100644
--- a/fxbarcode/datamatrix/BC_SymbolInfo.cpp
+++ b/fxbarcode/datamatrix/BC_SymbolInfo.cpp
@@ -106,8 +106,7 @@
     case 36:
       return 6;
     default:
-      NOTREACHED();
-      return 0;
+      NOTREACHED_NORETURN();
   }
 }
 
@@ -124,8 +123,7 @@
     case 36:
       return 6;
     default:
-      NOTREACHED();
-      return 0;
+      NOTREACHED_NORETURN();
   }
 }
 

fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp

diff --git a/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp b/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp
index f518c8b..10fac61 100644
--- a/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp
+++ b/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp
@@ -196,8 +196,7 @@
       intermediate = (((temp % 3) + ((y + x) & 0x1)) & 0x1);
       break;
     default:
-      NOTREACHED();
-      return false;
+      NOTREACHED_NORETURN();
   }
   return intermediate == 0;
 }