commit c116e597ef4dfac88248d6de0e7c9bdf093b6e7c
author dsinclair <dsinclair@chromium.org> Mon Aug 29 13:08:25 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Aug 29 13:08:25 2016 -0700
tree 94d75c895e6ad0a68ba000393e1e4251d93428f7
parent 91ddd3f7501429222f648b986a99f3959a398889

Verify element exists before accessing.

Currently when the parser utility classes are outputting to a text buffer we do
not verify that an element from an array exists before accessing. We can have
null items in arrays (and dictionaries but the dictionary case is already
handled).

This Cl updates the code to check the element exists before attempting to use
the element.

BUG=chromium:641076

Review-Url: https://codereview.chromium.org/2292473004

core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp
index a738356..6b19582 100644
--- a/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp
+++ b/core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp
@@ -179,7 +179,7 @@
       buf << "[";
       for (size_t i = 0; i < p->GetCount(); i++) {
         CPDF_Object* pElement = p->GetObjectAt(i);
-        if (pElement->GetObjNum()) {
+        if (pElement && pElement->GetObjNum()) {
           buf << " " << pElement->GetObjNum() << " 0 R";
         } else {
           buf << pElement;