commit c58babd220a9dc4d13757be8799bffbd59cac73b
author Tom Sepez <tsepez@chromium.org> Tue Jan 14 20:04:16 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jan 14 20:04:16 2020 +0000
tree 2fd45694d9c061ac39ec6e5b2fa83ffa27ea3dd5
parent 87c415ae7a36a81779ba77c5ebfc4892a7783ae7

Initialize more fwl classes in header.

Provide initializers for scalars even if we think they will be changed
before use. Tidy/pack while at it, prefer scalars with initializers
before classes which initialize themselves.

Change-Id: If766cbc3445222e0eeb1676be73e6ca88282974c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65012
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fwl/cfwl_barcode.h

diff --git a/xfa/fwl/cfwl_barcode.h b/xfa/fwl/cfwl_barcode.h
index 64a21d3..d2cd716 100644
--- a/xfa/fwl/cfwl_barcode.h
+++ b/xfa/fwl/cfwl_barcode.h
@@ -69,21 +69,21 @@
   void GenerateBarcodeImageCache();
   void CreateBarcodeEngine();
 
-  std::unique_ptr<CFX_Barcode> m_pBarcodeEngine;
-  Status m_eStatus = Status::kNormal;
   BC_TYPE m_type = BC_UNKNOWN;
-  BC_CHAR_ENCODING m_eCharEncoding;
-  int32_t m_nModuleHeight;
-  int32_t m_nModuleWidth;
-  int32_t m_nDataLength;
-  bool m_bCalChecksum;
-  bool m_bPrintChecksum;
-  BC_TEXT_LOC m_eTextLocation;
-  int8_t m_nWideNarrowRatio;
-  char m_cStartChar;
-  char m_cEndChar;
-  int32_t m_nECLevel;
+  BC_CHAR_ENCODING m_eCharEncoding = CHAR_ENCODING_UTF8;
+  BC_TEXT_LOC m_eTextLocation = BC_TEXT_LOC_NONE;
+  Status m_eStatus = Status::kNormal;
+  bool m_bCalChecksum = false;
+  bool m_bPrintChecksum = false;
+  char m_cStartChar = 0;
+  char m_cEndChar = 0;
+  int8_t m_nWideNarrowRatio = 1;
+  int32_t m_nModuleHeight = -1;
+  int32_t m_nModuleWidth = -1;
+  int32_t m_nDataLength = 0;
+  int32_t m_nECLevel = 0;
   uint32_t m_dwAttributeMask = 0;
+  std::unique_ptr<CFX_Barcode> m_pBarcodeEngine;
 };
 
 #endif  // XFA_FWL_CFWL_BARCODE_H_