commit ca86e90c090b412919d8dd5e5b046f69e6cc4570
author Lei Zhang <thestig@chromium.org> Tue Jun 09 22:12:34 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jun 09 22:12:34 2020 +0000
tree 974e7f9d9ac506be5e26dfc8ddbc9d6c37e25ba0
parent cb4203d1eed9139848fc335429397c49662ecdc0

Make length parameter in FPDFAttachment_SetFile() non-const.

This makes the API more consistent with other APIs. The const keyword
does not add much value to pass-by-value parameters.

Change-Id: I8c1967d39675eb246d4ffd8b075254ddef75149a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70470
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_attachment.cpp

diff --git a/fpdfsdk/fpdf_attachment.cpp b/fpdfsdk/fpdf_attachment.cpp
index b3324e6..da5e6e3 100644
--- a/fpdfsdk/fpdf_attachment.cpp
+++ b/fpdfsdk/fpdf_attachment.cpp
@@ -201,7 +201,7 @@
 FPDFAttachment_SetFile(FPDF_ATTACHMENT attachment,
                        FPDF_DOCUMENT document,
                        const void* contents,
-                       const unsigned long len) {
+                       unsigned long len) {
   CPDF_Object* pFile = CPDFObjectFromFPDFAttachment(attachment);
   CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(document);
   if (!pFile || !pFile->IsDictionary() || !pDoc || len > INT_MAX)

public/fpdf_attachment.h

diff --git a/public/fpdf_attachment.h b/public/fpdf_attachment.h
index 791a90b..afd4eb0 100644
--- a/public/fpdf_attachment.h
+++ b/public/fpdf_attachment.h
@@ -146,7 +146,7 @@
 FPDFAttachment_SetFile(FPDF_ATTACHMENT attachment,
                        FPDF_DOCUMENT document,
                        const void* contents,
-                       const unsigned long len);
+                       unsigned long len);
 
 // Experimental API.
 // Get the file data of |attachment|. |buffer| is only modified if |buflen| is