commit cb8a4ddc227732ee0bb0f8b48ee7c7d4dcac37a8
author Lei Zhang <thestig@chromium.org> Wed Nov 28 01:25:52 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Nov 28 01:25:52 2018 +0000
tree 5e182de60117ccce1d9ac1164a6671a6a0243fdc
parent 0f6f937705ed1b6ea3e6c0b45860523f708a7890

Get rid of "exceptions" in CBC_QRCoderBitVector::At().

Replace it with a CHECK() that should not fail since all the existing
callers check the bit vector's size.

Change-Id: Id90ca612766661959c7879754dc34ad401402fbd
Reviewed-on: https://pdfium-review.googlesource.com/c/45767
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxbarcode/qrcode/BC_QRCoderBitVector.cpp

diff --git a/fxbarcode/qrcode/BC_QRCoderBitVector.cpp b/fxbarcode/qrcode/BC_QRCoderBitVector.cpp
index 7a41ad0..09dddc3 100644
--- a/fxbarcode/qrcode/BC_QRCoderBitVector.cpp
+++ b/fxbarcode/qrcode/BC_QRCoderBitVector.cpp
@@ -25,15 +25,12 @@
 #include "core/fxcrt/fx_memory.h"
 #include "fxbarcode/utils.h"
 
-CBC_QRCoderBitVector::CBC_QRCoderBitVector() {}
+CBC_QRCoderBitVector::CBC_QRCoderBitVector() = default;
 
-CBC_QRCoderBitVector::~CBC_QRCoderBitVector() {}
+CBC_QRCoderBitVector::~CBC_QRCoderBitVector() = default;
 
-int32_t CBC_QRCoderBitVector::At(size_t index, int32_t& e) const {
-  if (index >= m_sizeInBits) {
-    e = BCExceptionBadIndexException;
-    return 0;
-  }
+int32_t CBC_QRCoderBitVector::At(size_t index) const {
+  CHECK(index < m_sizeInBits);
   int32_t value = m_array[index >> 3] & 0xff;
   return (value >> (7 - (index & 0x7))) & 1;
 }
@@ -73,14 +70,9 @@
   }
 }
 
-void CBC_QRCoderBitVector::AppendBitVector(CBC_QRCoderBitVector* bits) {
-  int32_t size = bits->Size();
-  for (int32_t i = 0; i < size; i++) {
-    int e = BCExceptionNO;
-    int32_t num = bits->At(i, e);
-    ASSERT(e == BCExceptionNO);
-    AppendBit(num);
-  }
+void CBC_QRCoderBitVector::AppendBitVector(const CBC_QRCoderBitVector* bits) {
+  for (size_t i = 0; i < bits->Size(); i++)
+    AppendBit(bits->At(i));
 }
 
 bool CBC_QRCoderBitVector::XOR(const CBC_QRCoderBitVector* other) {