commit cc4d6d85b58a7a1d9d7b798c63d3343f3dac06a9
author tsepez <tsepez@chromium.org> Mon May 16 13:21:03 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon May 16 13:21:03 2016 -0700
tree fda580a573f97d15c9484c57ebf8fae66342ab83
parent e699c66433049396e438d983a1837b9d4a4cf766

Remove { delete this; } anti-pattern from IXFA_WidgetIterator

Review-Url: https://codereview.chromium.org/1976123003

xfa/fxfa/include/xfa_ffpageview.h

diff --git a/xfa/fxfa/include/xfa_ffpageview.h b/xfa/fxfa/include/xfa_ffpageview.h
index 75e418b..79b0afb 100644
--- a/xfa/fxfa/include/xfa_ffpageview.h
+++ b/xfa/fxfa/include/xfa_ffpageview.h
@@ -36,12 +36,11 @@
 typedef CXFA_NodeIteratorTemplate<CXFA_LayoutItem,
                                   CXFA_TraverseStrategy_LayoutItem>
     CXFA_LayoutItemIterator;
+
 class CXFA_FFPageWidgetIterator : public IXFA_WidgetIterator {
  public:
   CXFA_FFPageWidgetIterator(CXFA_FFPageView* pPageView, uint32_t dwFilter);
-  virtual ~CXFA_FFPageWidgetIterator();
-
-  void Release() override { delete this; }
+  ~CXFA_FFPageWidgetIterator() override;
 
   void Reset() override;
   CXFA_FFWidget* MoveToFirst() override;
@@ -73,9 +72,7 @@
  public:
   CXFA_FFTabOrderPageWidgetIterator(CXFA_FFPageView* pPageView,
                                     uint32_t dwFilter);
-  virtual ~CXFA_FFTabOrderPageWidgetIterator();
-
-  void Release() override;
+  ~CXFA_FFTabOrderPageWidgetIterator() override;
 
   void Reset() override;
   CXFA_FFWidget* MoveToFirst() override;