commit cc534b45e0aa8becddc6da09732f13aff07a6d6d
author Lei Zhang <thestig@chromium.org> Mon Mar 24 14:36:01 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 24 14:36:01 2025 -0700
tree e74fc8a512605c87b5f7487e96a135034f743b83
parent 24779b0611941160ac160cf0d0da1f2c5699060a

Reuse AnnotationStampWithApChecksum()

Use AnnotationStampWithApChecksum() to replace identical code.

Change-Id: I8a668ffc3a37cf2d85d4cb16aab47e0c99eec8c5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129870
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_annot_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_annot_embeddertest.cpp b/fpdfsdk/fpdf_annot_embeddertest.cpp
index 60889e0..29a2781 100644
--- a/fpdfsdk/fpdf_annot_embeddertest.cpp
+++ b/fpdfsdk/fpdf_annot_embeddertest.cpp
@@ -1639,28 +1639,11 @@
   // Save the document and close the page.
   EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
 
-  const char* md5 = []() {
-    if (CFX_DefaultRenderDevice::UseSkiaRenderer()) {
-#if BUILDFLAG(IS_WIN)
-      return "d0dfc003b3e08160e698355b599f7eb8";
-#elif BUILDFLAG(IS_APPLE)
-      return "8774ac1779ea66056860290ae7df8f44";
-#else
-      return "8b8618de537ec6aee1f3fc53fedfbcfc";
-#endif
-    }
-#if BUILDFLAG(IS_APPLE)
-    return "587311ad93447614cbe5887df14caa78";
-#else
-    return "2908fd6166f795dfd73c607ec12c5356";
-#endif
-  }();
-
   // Open the saved annotation.
   ASSERT_TRUE(OpenSavedDocument());
   FPDF_PAGE saved_page = LoadSavedPage(0);
   ASSERT_TRUE(saved_page);
-  VerifySavedRendering(saved_page, 595, 842, md5);
+  VerifySavedRendering(saved_page, 595, 842, AnnotationStampWithApChecksum());
   {
     ScopedFPDFAnnotation new_annot(FPDFPage_GetAnnot(saved_page, 0));