Actually remove pdfium::make_span().
Previous CL has converted all of its callers to use CTAD instead.
Fixed: 42271100
Change-Id: Ibe6374a2d951ba8df30235de451fb9d7b3a28cbc
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/131211
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/core/fxcrt/span.h b/core/fxcrt/span.h
index b4d58e0..d6e9237 100644
--- a/core/fxcrt/span.h
+++ b/core/fxcrt/span.h
@@ -16,7 +16,6 @@
// - removed any references to std::string_view.
// - removed any references to base::cstring_view<>.
// - Added reinterpret_span() helper.
-// - Added make_span() helper method to ease conversion to CTAD.
// - DCHECK() verbose logging message not supported and removed.
// - Kept EnableIfSpanCompatibleContainer as in prior versions.
@@ -1659,42 +1658,6 @@
return as_writable_bytes(allow_nonunique_obj, span<ElementType, Extent>(arr));
}
-// Type-deducing helpers for constructing a span.
-template <typename T>
-UNSAFE_BUFFER_USAGE constexpr span<T> make_span(T* data, size_t size) noexcept {
- return UNSAFE_BUFFERS(span<T>(data, size));
-}
-
-template <typename T, size_t N>
-constexpr span<T> make_span(T (&array)[N]) noexcept {
- return span<T>(array);
-}
-
-template <typename T, size_t N>
-constexpr span<T> make_span(std::array<T, N>& array) noexcept {
- return span<T>(array);
-}
-
-template <typename T, size_t N>
-constexpr span<const T> make_span(const std::array<T, N>& array) noexcept {
- return span<const T>(const_cast<std::array<T, N>&>(array));
-}
-
-template <typename Container,
- typename T = typename Container::value_type,
- typename = internal::EnableIfSpanCompatibleContainer<Container, T>>
-constexpr span<T> make_span(Container& container) {
- return span<T>(container);
-}
-
-template <
- typename Container,
- typename T = typename std::add_const<typename Container::value_type>::type,
- typename = internal::EnableIfConstSpanCompatibleContainer<Container, T>>
-constexpr span<T> make_span(const Container& container) {
- return span<T>(container);
-}
-
} // namespace pdfium
#endif // BASE_CONTAINERS_SPAN_H_